You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/26 14:02:27 UTC
[GitHub] [flink] HuangXingBo opened a new pull request #11224:
[FLINK-16252][python] Optimize the progress of the process_outputs in
Python UDF
HuangXingBo opened a new pull request #11224: [FLINK-16252][python] Optimize the progress of the process_outputs in Python UDF
URL: https://github.com/apache/flink/pull/11224
## What is the purpose of the change
*This pull request will optimize the progress of the process_outputs in Python UDF*
## Brief change log
- *Using value_coder to encode_stream directly in ScalarOperation*
## Verifying this change
This change added tests and can be verified as follows:
- *It is a perforce improvement without extra function test*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
## How does this patch test
### Test Code
@udf(input_types=[DataTypes.INT(False)], result_type=DataTypes.INT(False))
def inc(x):
return x
t_env.register_function("inc", inc)
# num_rows = 100000000
num_rows = 100000
num_columns = 100
select_list = ["inc(c%s)" % i for i in range(num_columns)]
t_env.register_table_sink(
"sink",
PrintTableSink(
["c%s" % i for i in range(num_columns)],
[DataTypes.INT(False)] * num_columns))
t_env.from_table_source(MultiRowColumnTableSource(num_rows, num_columns)) \
.select(','.join(select_list)) \
.insert_into("sink")
beg_time = time.time()
t_env.execute("perf_test")
print("consume time: " + str(time.time() - beg_time))
## Test Results
num rows, num colums | Consume Time(Before) | Consume Time(After)
1000w,1 | 90.60 | 76.47
1000w,10 | 164.36 | 148.87
100000000, 1 | 784 | 739
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11224: [FLINK-16252][python]
Optimize the progress of the process_outputs in Python UDF
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11224: [FLINK-16252][python] Optimize the progress of the process_outputs in Python UDF
URL: https://github.com/apache/flink/pull/11224#issuecomment-591442818
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit bd21a4f16dc0b820a890154bb504842246e22bf7 (Wed Feb 26 14:06:18 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11224:
[FLINK-16252][python] Optimize the progress of the process_outputs in
Python UDF
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11224: [FLINK-16252][python] Optimize the progress of the process_outputs in Python UDF
URL: https://github.com/apache/flink/pull/11224#issuecomment-591447740
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bd21a4f16dc0b820a890154bb504842246e22bf7",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150662263",
"triggerID" : "bd21a4f16dc0b820a890154bb504842246e22bf7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bd21a4f16dc0b820a890154bb504842246e22bf7 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150662263)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dianfu commented on issue #11224: [FLINK-16252][python]
Optimize the progress of the process_outputs in Python UDF
Posted by GitBox <gi...@apache.org>.
dianfu commented on issue #11224: [FLINK-16252][python] Optimize the progress of the process_outputs in Python UDF
URL: https://github.com/apache/flink/pull/11224#issuecomment-591801113
@HuangXingBo Thanks for the PR. LGTM. The test failure is not related to this PR and has been tracked in https://issues.apache.org/jira/browse/FLINK-13553.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11224:
[FLINK-16252][python] Optimize the output emit logic to remove unnecessary
overhead
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11224: [FLINK-16252][python] Optimize the output emit logic to remove unnecessary overhead
URL: https://github.com/apache/flink/pull/11224#issuecomment-591442818
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit bd21a4f16dc0b820a890154bb504842246e22bf7 (Fri Feb 28 21:48:43 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11224:
[FLINK-16252][python] Optimize the progress of the process_outputs in
Python UDF
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11224: [FLINK-16252][python] Optimize the progress of the process_outputs in Python UDF
URL: https://github.com/apache/flink/pull/11224#issuecomment-591447740
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bd21a4f16dc0b820a890154bb504842246e22bf7",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150662263",
"triggerID" : "bd21a4f16dc0b820a890154bb504842246e22bf7",
"triggerType" : "PUSH"
}, {
"hash" : "bd21a4f16dc0b820a890154bb504842246e22bf7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5640",
"triggerID" : "bd21a4f16dc0b820a890154bb504842246e22bf7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bd21a4f16dc0b820a890154bb504842246e22bf7 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/150662263) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5640)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11224: [FLINK-16252][python]
Optimize the progress of the process_outputs in Python UDF
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11224: [FLINK-16252][python] Optimize the progress of the process_outputs in Python UDF
URL: https://github.com/apache/flink/pull/11224#issuecomment-591447740
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bd21a4f16dc0b820a890154bb504842246e22bf7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bd21a4f16dc0b820a890154bb504842246e22bf7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bd21a4f16dc0b820a890154bb504842246e22bf7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11224:
[FLINK-16252][python] Optimize the progress of the process_outputs in
Python UDF
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11224: [FLINK-16252][python] Optimize the progress of the process_outputs in Python UDF
URL: https://github.com/apache/flink/pull/11224#issuecomment-591447740
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bd21a4f16dc0b820a890154bb504842246e22bf7",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150662263",
"triggerID" : "bd21a4f16dc0b820a890154bb504842246e22bf7",
"triggerType" : "PUSH"
}, {
"hash" : "bd21a4f16dc0b820a890154bb504842246e22bf7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5640",
"triggerID" : "bd21a4f16dc0b820a890154bb504842246e22bf7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bd21a4f16dc0b820a890154bb504842246e22bf7 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150662263) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5640)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dianfu merged pull request #11224: [FLINK-16252][python]
Optimize the progress of the process_outputs in Python UDF
Posted by GitBox <gi...@apache.org>.
dianfu merged pull request #11224: [FLINK-16252][python] Optimize the progress of the process_outputs in Python UDF
URL: https://github.com/apache/flink/pull/11224
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services