You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/16 12:09:54 UTC

[GitHub] [airflow] ashb opened a new pull request #14833: Speed up tests/api/ from 20s down to 6s

ashb opened a new pull request #14833:
URL: https://github.com/apache/airflow/pull/14833


   Not a big over-all speed up, but also not a big change
   
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb merged pull request #14833: Speed up tests/api/ from 20s down to 6s

Posted by GitBox <gi...@apache.org>.
ashb merged pull request #14833:
URL: https://github.com/apache/airflow/pull/14833


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on a change in pull request #14833: Speed up tests/api/ from 20s down to 6s

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #14833:
URL: https://github.com/apache/airflow/pull/14833#discussion_r595109243



##########
File path: tests/api/common/experimental/test_mark_tasks.py
##########
@@ -68,22 +63,19 @@ def setUp(self):
         )
         for dr in drs:
             dr.dag = self.dag1
-            dr.verify_integrity()
 
         drs = _create_dagruns(
             self.dag2, [self.dag2.start_date], state=State.RUNNING, run_type=DagRunType.SCHEDULED
         )
 
         for dr in drs:
             dr.dag = self.dag2
-            dr.verify_integrity()
 
         drs = _create_dagruns(
             self.dag3, self.dag3_execution_dates, state=State.SUCCESS, run_type=DagRunType.MANUAL
         )
         for dr in drs:
             dr.dag = self.dag3
-            dr.verify_integrity()

Review comment:
       Called when creating the dag run, we don't need to do again.

##########
File path: tests/api/common/experimental/test_mark_tasks.py
##########
@@ -568,8 +560,6 @@ def test_set_failed_dag_run_to_running(self):
         middle_time = timezone.utcnow()
         self._set_default_task_instance_states(dr)
 
-        time.sleep(2)

Review comment:
       Doesn't seem  to have any effect.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #14833: Speed up tests/api/ from 20s down to 6s

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #14833:
URL: https://github.com/apache/airflow/pull/14833#issuecomment-800253635


   +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on a change in pull request #14833: Speed up tests/api/ from 20s down to 6s

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #14833:
URL: https://github.com/apache/airflow/pull/14833#discussion_r595108997



##########
File path: pylintrc-tests
##########
@@ -389,7 +389,7 @@ min-similarity-lines=4
 # Regular expression matching correct argument names. Overrides argument-
 # naming-style.
 # BasPH: Kept snake_case but allow for 1-char argument names.
-argument-rgx=[a-z_][a-z0-9_]{0,30}$
+argument-rgx=[a-z_][a-z0-9_]{0,32}$

Review comment:
       `minimal_app_for_experimental_api` was longer than 30 characters.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org