You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Nathan Beyer (JIRA)" <ji...@apache.org> on 2006/12/04 03:02:22 UTC

[jira] Commented: (HARMONY-2383) [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody

    [ http://issues.apache.org/jira/browse/HARMONY-2383?page=comments#action_12455228 ] 
            
Nathan Beyer commented on HARMONY-2383:
---------------------------------------

Can you split the patch into multiple patch files? These run across many different classes and fix many different things. I'd like to review each independently.

I do have one concern after initial review and that's the elimination of some of the 'transient' keywords. This could have a serious impact on the serialization of classes. Have you validated the serialization compatibility?

> [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
> --------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2383
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2383
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Sian January
>            Priority: Minor
>         Attachments: findbugspatch.txt
>
>
> I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira