You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "gerlowskija (via GitHub)" <gi...@apache.org> on 2023/06/27 14:30:50 UTC
[GitHub] [solr] gerlowskija opened a new pull request, #1726: SOLR-16840: Workaround HK2 DI bug
gerlowskija opened a new pull request, #1726:
URL: https://github.com/apache/solr/pull/1726
https://issues.apache.org/jira/browse/SOLR-16840
# Description
Prior to this commit many v2 invocations would succeed but log scary looking stacktraces to Solr's console log. This was because of a bug in how Jersey creates and cleans up "RequestScoped" objects. (See Jersey#3503 for more details.)
# Solution
This commit works around the bug by changing how several "factory" classes obtain a "ContainerRequestContext": switching away from DI and towards looking up the CRC more explicitly using a "ServiceLocator".
# Tests
Manual testing to verify that the warning stacktraces no longer appear in Solr's console logging. Automated tests continue to pass.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #1726: SOLR-16840: Workaround HK2 DI bug
Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman commented on PR #1726:
URL: https://github.com/apache/solr/pull/1726#issuecomment-1611841342
So the Github Issue that Jason linked has been open for 6 years, and not closed. So definitely not an upgrade issue.
Yeah we can probably link the Issue url in a comment somewhere, so this is documented in the code. Good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija commented on pull request #1726: SOLR-16840: Workaround HK2 DI bug
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on PR #1726:
URL: https://github.com/apache/solr/pull/1726#issuecomment-1615076263
> are we behind on our version of Glassfish and HK2?
No, we're not behind on hk2 - it's just a long standing bug I guess. I've added a comment as you guy suggested to we can use more conventional injection when the bug does eventually get fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija merged pull request #1726: SOLR-16840: Workaround HK2 DI bug
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija merged PR #1726:
URL: https://github.com/apache/solr/pull/1726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org