You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ce...@apache.org on 2014/03/08 09:41:25 UTC

svn commit: r1575501 - in /poi/trunk/src: java/org/apache/poi/hssf/usermodel/DummyGraphics2d.java ooxml/java/org/apache/poi/xssf/streaming/SheetDataWriter.java

Author: centic
Date: Sat Mar  8 08:41:25 2014
New Revision: 1575501

URL: http://svn.apache.org/r1575501
Log:
Fix Sonar issues about finalize() usage

Modified:
    poi/trunk/src/java/org/apache/poi/hssf/usermodel/DummyGraphics2d.java
    poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SheetDataWriter.java

Modified: poi/trunk/src/java/org/apache/poi/hssf/usermodel/DummyGraphics2d.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/usermodel/DummyGraphics2d.java?rev=1575501&r1=1575500&r2=1575501&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/usermodel/DummyGraphics2d.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/usermodel/DummyGraphics2d.java Sat Mar  8 08:41:25 2014
@@ -19,16 +19,16 @@
 package org.apache.poi.hssf.usermodel;
 
 import java.awt.*;
+import java.awt.font.FontRenderContext;
+import java.awt.font.GlyphVector;
 import java.awt.geom.AffineTransform;
 import java.awt.image.BufferedImage;
 import java.awt.image.BufferedImageOp;
 import java.awt.image.ImageObserver;
 import java.awt.image.RenderedImage;
 import java.awt.image.renderable.RenderableImage;
-import java.awt.font.GlyphVector;
-import java.awt.font.FontRenderContext;
-import java.util.Map;
 import java.text.AttributedCharacterIterator;
+import java.util.Map;
 
 public class DummyGraphics2d
         extends Graphics2D
@@ -675,6 +675,8 @@ public class DummyGraphics2d
     public void finalize() {
         System.out.println( "finalize():" );
         g2D.finalize();
+
+        super.finalize();
     }
 
     public Shape getClip()

Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SheetDataWriter.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SheetDataWriter.java?rev=1575501&r1=1575500&r2=1575501&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SheetDataWriter.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SheetDataWriter.java Sat Mar  8 08:41:25 2014
@@ -127,6 +127,8 @@ public class SheetDataWriter {
     @Override
     protected void finalize() throws Throwable {
         _fd.delete();
+
+        super.finalize();
     }
 
     /**



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org