You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/06/16 14:52:31 UTC
[GitHub] [skywalking] kezhenxu94 opened a new pull request #2882: Lift
checkstyle config to plugin level
kezhenxu94 opened a new pull request #2882: Lift checkstyle config to plugin level
URL: https://github.com/apache/skywalking/pull/2882
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New feature provided
- [ ] Improve performance
___
### Bug fix
- Bug description.
the configurations of `checkstyle` is placed in the `execution` tag, running `mvn checkstyle:check` won't take those configs and use the built-in checkstyle configs (such as Sun or Google), but `mvn process-sources` will cause other unwanted tasks (e.g. jacoco, enforcer), this patch allows running `mvn checkstyle:check` without extra efforts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services