You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by RomainFallet <gi...@git.apache.org> on 2015/08/12 12:12:45 UTC
[GitHub] cordova-plugin-dialogs pull request: set cancelable to false by de...
GitHub user RomainFallet opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/56
set cancelable to false by default on Android
To match with the iOS behavior where all modals cannot be canceled by a click outside of it (or a back button).
First of all, there is few case where it is interesting for the developper to let the user dismiss the modal by a simple click outside of the modal. And it's absolutely not user friendly, the user does not attempt to see the modal closing after this action. He can cancel it unintentionally.
Maybe a setting would be a great solution too ?
Here some testimonies of developers that have trouble with this (not only with cordova) :
https://github.com/jquery/jquery-mobile/issues/4727
http://stackoverflow.com/questions/23300122/prevent-phonegap-notification-navigator-popups-from-closing-from-touch-outside-o
http://programming.nullanswer.com/question/27626010
http://iswwwup.com/t/5fcbb227c8f7/javascript-prevent-kendo-tooltip-hide-close-when-clicking-outside-the-tooltip.html
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RomainFallet/cordova-plugin-dialogs master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-dialogs/pull/56.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #56
----
commit b6c48989a18e3f0a27c04a68982ceb819834a715
Author: Romain Fallet <ro...@outlook.com>
Date: 2015-08-12T09:52:08Z
set cancelable to false by default on Android
To match with the iOS behavior where all modals cannot be canceled by a click outside of it (or a back button).
First of all, there is no case where it is interesting for the developper to let the user dismiss the modal by a simple click outside of the modal. And it's absolutely not user friendly, the user does not attempt to see the modal closing after this action.
Here some testimonies of developers that have trouble with this (not only with cordova) :
https://github.com/jquery/jquery-mobile/issues/4727
http://stackoverflow.com/questions/23300122/prevent-phonegap-notification-navigator-popups-from-closing-from-touch-outside-o
http://programming.nullanswer.com/question/27626010
http://iswwwup.com/t/5fcbb227c8f7/javascript-prevent-kendo-tooltip-hide-close-when-clicking-outside-the-tooltip.html
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: set cancelable to false by de...
Posted by kavka3 <gi...@git.apache.org>.
Github user kavka3 commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/56#issuecomment-144113273
++
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: set cancelable to false by de...
Posted by Heshyo <gi...@git.apache.org>.
Github user Heshyo commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/56#issuecomment-152468218
I just saw https://github.com/apache/cordova-plugin-dialogs/pull/60 that actually added a ```setCanceledOnTouchOutside```. I don't know if both ```setCanceled``` and ```setCanceledOnTouchOutside``` should be set (in my app I only use ```setCanceled(false)``` and it prevents both back button and clicking outside to close the dialog).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs issue #56: set cancelable to false by default on Andr...
Posted by darron1217 <gi...@git.apache.org>.
Github user darron1217 commented on the issue:
https://github.com/apache/cordova-plugin-dialogs/pull/56
++
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: set cancelable to false by de...
Posted by Heshyo <gi...@git.apache.org>.
Github user Heshyo commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/56#issuecomment-152465106
++
It's easy to tap outside of the box unintentionally. Also you may wonder what happens if you tap outside instead of clicking OK/Cancel (did I just OKed or Cancelled it?).
I'm actually already using a modified version of this plugin just to change that ```setCancelable``` part.
@RomainFallet maybe you could simply update the calls to ```alert```, ```confirm```, ... and add another argument ```isCancelable``` that would default to ```false``` as to not change the current behavior on Android. Maybe people don't want to merge the PR as it's not backward compatible?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs issue #56: set cancelable to false by default on Andr...
Posted by roushd5 <gi...@git.apache.org>.
Github user roushd5 commented on the issue:
https://github.com/apache/cordova-plugin-dialogs/pull/56
++
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org