You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "RatulDawar (via GitHub)" <gi...@apache.org> on 2026/04/20 18:23:05 UTC
[PR] test: add tests for spill file sizes to verify View GC [datafusion]
RatulDawar opened a new pull request, #21748:
URL: https://github.com/apache/datafusion/pull/21748
## Summary
This PR adds unit tests to verify that `StringView` and `BinaryView` arrays are correctly compacted (garbage collected) before being spilled to disk.
The tests address [Issue #21683](https://github.com/apache/datafusion/issues/21683) by:
1. Creating "bloated" batches with large underlying buffers.
2. Slicing them to a small number of rows (1%).
3. Spilling them to disk.
4. Asserting that the resulting file size is small (proving that GC removed the unused "ghost" data).
## Test plan
- Run `cargo test -p datafusion-physical-plan --lib spill::mod::tests::test_spill_file_size_gc_verification_string_view`
- Run `cargo test -p datafusion-physical-plan --lib spill::mod::tests::test_spill_file_size_gc_verification_binary_view`
Made with [Cursor](https://cursor.com)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] test: add tests for spill file sizes to verify View GC [datafusion]
Posted by "RatulDawar (via GitHub)" <gi...@apache.org>.
RatulDawar closed pull request #21748: test: add tests for spill file sizes to verify View GC
URL: https://github.com/apache/datafusion/pull/21748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org