You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/06/21 16:45:15 UTC
[kudu-CR](branch-1.10.x) [backup] Fix backup tools packaging
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13705
Change subject: [backup] Fix backup tools packaging
......................................................................
[backup] Fix backup tools packaging
This patch adjusts how we package the kudu-backup-tools
module. Instead of building a fat jar that contains all of
the hadoop classes, the hadoop classes are now marked
as provided and therfore not included.
This change was made with two concerns in mind.
Primarily because the defacto way to load the
environments hadoop configuration is from the
classpath via `hadoop classpath`. A secondary benefit
is that loading the classpath this way avoids any
potential hadoop compatibility issues.
An example execution of the jar would now be:
`java -cp $(hadoop classpath):kudu-backup-tools-1.10.0.jar org.apache.kudu.backup.KuduBackupCLI`
Additionally this patch adds integration tests for the
`hdfs` uri in the tests using a hadoop-minicluster.
Change-Id: I334a38bb5d7252b5e6d2722c4f1fc1d3b5622db7
Reviewed-on: http://gerrit.cloudera.org:8080/13691
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
(cherry picked from commit ef921b2c35589e75de4c3fcb2673e38123d9fb94)
---
M java/gradle/dependencies.gradle
M java/gradle/shadow.gradle
M java/kudu-backup-common/build.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-backup-tools/src/main/scala/org/apache/kudu/backup/KuduBackupLister.scala
M java/kudu-backup-tools/src/test/scala/org/apache/kudu/backup/TestKuduBackupCleaner.scala
M java/kudu-backup-tools/src/test/scala/org/apache/kudu/backup/TestKuduBackupLister.scala
7 files changed, 99 insertions(+), 80 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/13705/1
--
To view, visit http://gerrit.cloudera.org:8080/13705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I334a38bb5d7252b5e6d2722c4f1fc1d3b5622db7
Gerrit-Change-Number: 13705
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR](branch-1.10.x) [backup] Fix backup tools packaging
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13705 )
Change subject: [backup] Fix backup tools packaging
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I334a38bb5d7252b5e6d2722c4f1fc1d3b5622db7
Gerrit-Change-Number: 13705
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 21 Jun 2019 17:33:39 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.10.x) [backup] Fix backup tools packaging
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13705 )
Change subject: [backup] Fix backup tools packaging
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I334a38bb5d7252b5e6d2722c4f1fc1d3b5622db7
Gerrit-Change-Number: 13705
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 21 Jun 2019 17:29:50 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.10.x) [backup] Fix backup tools packaging
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: [backup] Fix backup tools packaging
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I334a38bb5d7252b5e6d2722c4f1fc1d3b5622db7
Gerrit-Change-Number: 13705
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.10.x) [backup] Fix backup tools packaging
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13705 )
Change subject: [backup] Fix backup tools packaging
......................................................................
[backup] Fix backup tools packaging
This patch adjusts how we package the kudu-backup-tools
module. Instead of building a fat jar that contains all of
the hadoop classes, the hadoop classes are now marked
as provided and therfore not included.
This change was made with two concerns in mind.
Primarily because the defacto way to load the
environments hadoop configuration is from the
classpath via `hadoop classpath`. A secondary benefit
is that loading the classpath this way avoids any
potential hadoop compatibility issues.
An example execution of the jar would now be:
`java -cp $(hadoop classpath):kudu-backup-tools-1.10.0.jar org.apache.kudu.backup.KuduBackupCLI`
Additionally this patch adds integration tests for the
`hdfs` uri in the tests using a hadoop-minicluster.
Change-Id: I334a38bb5d7252b5e6d2722c4f1fc1d3b5622db7
Reviewed-on: http://gerrit.cloudera.org:8080/13691
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
(cherry picked from commit ef921b2c35589e75de4c3fcb2673e38123d9fb94)
Reviewed-on: http://gerrit.cloudera.org:8080/13705
Tested-by: Grant Henke <gr...@apache.org>
---
M java/gradle/dependencies.gradle
M java/gradle/shadow.gradle
M java/kudu-backup-common/build.gradle
M java/kudu-backup-tools/build.gradle
M java/kudu-backup-tools/src/main/scala/org/apache/kudu/backup/KuduBackupLister.scala
M java/kudu-backup-tools/src/test/scala/org/apache/kudu/backup/TestKuduBackupCleaner.scala
M java/kudu-backup-tools/src/test/scala/org/apache/kudu/backup/TestKuduBackupLister.scala
7 files changed, 99 insertions(+), 80 deletions(-)
Approvals:
Grant Henke: Verified
Mike Percy: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I334a38bb5d7252b5e6d2722c4f1fc1d3b5622db7
Gerrit-Change-Number: 13705
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>