You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2013/07/07 03:11:30 UTC

[Bug 55207] New: In XML syntax, jsp:text does not error on sub-elements from other namespaces

https://issues.apache.org/bugzilla/show_bug.cgi?id=55207

            Bug ID: 55207
           Summary: In XML syntax, jsp:text does not error on sub-elements
                    from other namespaces
           Product: Tomcat 8
           Version: trunk
          Hardware: PC
                OS: Mac OS X 10.4
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Jasper
          Assignee: dev@tomcat.apache.org
          Reporter: jboynes@apache.org

Created attachment 30557
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30557&action=edit
patch to reject on any element inside <jsp:text>

JspDocumentParser does check for sub-elements within a jsp:text element but
only fails if they are from the jsp namespace

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 55207] In XML syntax, jsp:text does not error on sub-elements from other namespaces

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55207

--- Comment #2 from Jeremy Boynes <jb...@apache.org> ---
Created attachment 30559
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30559&action=edit
patch to reject on any element inside <jsp:text>

There is an additional problem here in that the check is assuming the name of
the <jsp:text> node is "jsp:text" - it does not allow for the case where a
different prefix is being used. This applies to the current implementation as
well where nested <foo:text><foo:text> will not error if foo: is the JSP
namespace.

Updated the check to use the type of the parent Node rather than the XML

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 55207] In XML syntax, jsp:text does not error on sub-elements from other namespaces

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55207

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Mark Thomas <ma...@apache.org> ---
Thanks for the patch. It has been applied to trunk and 7.0.x and will be
included in 7.0.43 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 55207] In XML syntax, jsp:text does not error on sub-elements from other namespaces

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55207

Jeremy Boynes <jb...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30557|0                           |1
        is obsolete|                            |

--- Comment #1 from Jeremy Boynes <jb...@apache.org> ---
Created attachment 30558
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30558&action=edit
patch to reject on any element inside <jsp:text>

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 55207] In XML syntax, jsp:text does not error on sub-elements from other namespaces

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55207

Jeremy Boynes <jb...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #30558|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org