You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Jon Foster <jo...@jon-foster.co.uk> on 2004/05/26 20:08:55 UTC
[PATCH] Re: Win32 neon build error (Spaces in path)
Hi,
My Neon fixes were included in Neon 0.24.6; here are the corresponding
Subversion changes. Note that the Subversion trunk already claims to
need this version of Neon, so this doesn't increase the stated system
requirements.
Log message:
---
Fix Win32 build when there are spaces in the path.
Neon versions prior to 0.24.6 would not allow us to quote EXPAT_FLAGS
correctly, so paths with spaces would not work. Although we could now
quote this correctly, it's better to use the new EXPAT_INC flag (also
introduced in Neon 0.24.6). Setting EXPAT_FLAGS requires too much
knowledge of Neon build-system internals.
* build_neon.ezt: Set EXPAT_INC rather than EXPAT_FLAGS.
---
My mailer is known to break inline patches, so I'm sending it as an
attachment. This patch is against the trunk.
Kind regards,
Jon
Jon Foster wrote:
> Hi,
>
> D.J. Heap wrote:
>
>> Jon Foster wrote:
>>
>>> Hi all,
>>>
>>> I've just built the Subversion trunk under Windows 2000, with MS Visual
>>> Studio .NET 2002. When building neon, the VS project runs
>>> build_neon.bat.
>>> This gave the error message:
>>>
>>> > Performing Makefile project actions
>>> > nmake /f neon.mak ALL EXPAT_FLAGS="/I
>>> >>> D:\My
>>> Documents\Jon\Prog\Subversion\Work\Subversion\apr-util/xml/expat/lib
>>> >>> /D HAVE_EXPAT /D HAVE_EXPAT_H" DEBUG_BUILD=Aye
>>> > NMAKE : fatal error U1073: don't know how to make 'D:\My'
>>> > Stop.
>>>
>>> The problem seems to be the space in the path; editing build_neon.bat
>>> to change "My Documents" to "MyDocu~1" fixes this.
>>>
>>> Is this a known bug?
>>>
>>> I can think of at least four ways to fix this:
>>> 1) Document "don't do that".
>>> 2) Come up with a way of quoting this properly.
>>> 3) Fix the python script that generates build_neon.bat to use the
>>> short file name.
>>> 4) Change Neon to allow the paths to be specified in some other way.
>>> (Would require changes to Neon as well as SVN).
>>
>> [snip]
>>
>> Can you try fixing it with quoting and posting a patch?
>>
>> DJ
>
> I tried, but I now believe it's impossible. The Neon makefile is
> just too broken. I just posted a couple of patches to the Neon
> list; if they get accepted then I'll provide the corresponding
> fixes to Subversion.
>
> Kind regards,
>
> Jon Foster
>
Re: [PATCH] Re: Win32 neon build error (Spaces in path)
Posted by "D.J. Heap" <dj...@shadyvale.net>.
Jon Foster wrote:
> Hi,
>
> My Neon fixes were included in Neon 0.24.6; here are the corresponding
> Subversion changes. Note that the Subversion trunk already claims to
> need this version of Neon, so this doesn't increase the stated system
> requirements.
[snip]
Committed in r9894, thanks!
DJ
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Re: Win32 neon build error (Spaces in path)
Posted by Jon Foster <jo...@jon-foster.co.uk>.
Hi,
Branko Čibej wrote:
> Note that the changes aren't strictly necessary -- setting EXPAT_FLAGS
> works just fine with neon-0.24.6.
Yes, setting EXPAT_FLAGS still works _if_ there aren't any spaces in
the Expat path, but the current code doesn't work if there are spaces
in the Expat path.
> But I agree it makes the batch file a wee bit more elegant.
> Thanks for the patch!
>
> D.J., could you test and commit this, please? I have something else on
> my plate right now; thanks.
Thanks!
Jon
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Re: Win32 neon build error (Spaces in path)
Posted by Branko Čibej <br...@xbc.nu>.
Jon Foster wrote:
> Hi,
>
> My Neon fixes were included in Neon 0.24.6; here are the corresponding
> Subversion changes. Note that the Subversion trunk already claims to
> need this version of Neon, so this doesn't increase the stated system
> requirements.
Note that the changes aren't strictly necessary -- setting EXPAT_FLAGS
works just fine with neon-0.24.6. But I agree it makes the batch file a
wee bit more elegant.
Thanks for the patch!
D.J., could you test and commit this, please? I have something else on
my plate right now; thanks.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org