Re: [PR] FINERACT-2165: Migrate Schedulerjobhelper internals to typed Feign cl… [fineract]

["elnafateh (via GitHub)" <gi...@apache.org>]

elnafateh commented on code in PR #6115:
URL: https://github.com/apache/fineract/pull/6115#discussion_r3695963115


##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/SchedulerJobHelper.java:
##########
@@ -18,175 +18,132 @@
  */
 package org.apache.fineract.integrationtests.common;
 
-import static org.apache.fineract.infrastructure.jobs.api.SchedulerJobApiConstants.SHORT_NAME_PARAM;
+import static org.apache.fineract.client.feign.util.FeignCalls.executeVoid;
+import static org.apache.fineract.client.feign.util.FeignCalls.ok;
 import static org.awaitility.Awaitility.await;
 import static org.hamcrest.core.Is.is;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.fail;
 
 import com.google.gson.Gson;
-import io.restassured.builder.ResponseSpecBuilder;
+import com.google.gson.GsonBuilder;
+import com.google.gson.JsonPrimitive;
+import com.google.gson.JsonSerializer;
 import io.restassured.specification.RequestSpecification;
-import io.restassured.specification.ResponseSpecification;
 import java.time.Duration;
-import java.util.HashMap;
+import java.time.LocalDate;
+import java.time.LocalDateTime;
+import java.time.OffsetDateTime;
+import java.time.format.DateTimeFormatter;
 import java.util.List;
 import java.util.Map;
 import java.util.function.Consumer;
 import java.util.function.Function;
 import java.util.stream.Collectors;
+import org.apache.fineract.client.models.CommandProcessingResult;
+import org.apache.fineract.client.models.ExecuteJobRequest;
 import org.apache.fineract.client.models.GetJobsResponse;
+import org.apache.fineract.client.models.GetSchedulerResponse;
 import org.apache.fineract.client.models.PutJobsJobIDRequest;
-import org.apache.fineract.client.util.Calls;
 import org.hamcrest.MatcherAssert;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+/**
+ * Feign-based. Still instance-shaped (see constructor) purely for source compatibility with existing call sites; a
+ * follow-up PR will static-ify this class and update all callers in one mechanical pass.
+ */
 public class SchedulerJobHelper {
 
     private static final Logger LOG = LoggerFactory.getLogger(SchedulerJobHelper.class);
-    private final RequestSpecification requestSpec;
-    private final ResponseSpecification response200Spec;
+    private static final Gson GSON = new GsonBuilder()

Review Comment:
   resolved



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org