You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2019/11/24 22:16:02 UTC

[GitHub] [fineract] maektwain opened a new pull request #650: Adding vnd.ms-excel support

maektwain opened a new pull request #650: Adding vnd.ms-excel support
URL: https://github.com/apache/fineract/pull/650
 
 
   ## Description
   When using an importer to download the template file for any specific Domain and while uploading the same template with filled data , it seems to fail. Debugging the problem made me realise that it had changed the file extension some how, No idea why it was happening maybe from the UI side. But I checked it was not the case.
   
   So I managed to put a condition which makes sure that we have this condition fulfilled also.
   
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
   
   - [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
   
   - [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
   
   - [ ] Integration tests have been created/updated for verifying the changes made.
   
   - [ ] All Integrations tests are passing with the new commits.
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services