You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "dannycranmer (via GitHub)" <gi...@apache.org> on 2023/01/27 14:59:33 UTC

[GitHub] [flink] dannycranmer commented on pull request #21666: [FLINK-30651]Remove CatalogUtilsTest class

dannycranmer commented on PR #21666:
URL: https://github.com/apache/flink/pull/21666#issuecomment-1406621094

   @Samrat002 I am not sure I am aligned with this change. It is a common practise to put static helper methods in a Util class. Personally I find it easier to follow the flow to `CatalogTestUtil.checkEquals()` instead of `checkEquals()` to some method in the super classes. Also leaving the util in `CatalogTestUtil` allows it to be reused by tests that do not sub `CatalogTest`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org