[jira] [Updated] (SLING-4307) Avoid caching JCR property values

["Radu Cotescu (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SLING-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Radu Cotescu updated SLING-4307:
--------------------------------
    Attachment: SLING-4307_stream_test.patch

The attached patch ([^SLING-4307_stream_test.patch]) proves that the code committed in rr1652218 / r1652219 introduced a regression when handling Binary properties supplied to the {{JcrModifiableValueMap}} as an {{InputStream}}.


> Avoid caching JCR property values
> ---------------------------------
>
>                 Key: SLING-4307
>                 URL: https://issues.apache.org/jira/browse/SLING-4307
>             Project: Sling
>          Issue Type: Improvement
>          Components: JCR
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>             Fix For: JCR Resource 2.4.0
>
>         Attachments: SLING-4307_stream_test.patch
>
>
> The support for ValueMap is currently caching the JCR Value objects and also the JCR Property object.
> If the value map object is held, this might prevent garbage collection within Oak as the value object holds a reference to the revision.
> We should check whether caching is needed at all or if for example we could just cache the value itself but not the JCR Value object



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)