You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/12/23 15:00:56 UTC
[GitHub] [maven] mthmulders opened a new pull request #414: [MNG-4660] Increase usefulness of logging
mthmulders opened a new pull request #414:
URL: https://github.com/apache/maven/pull/414
When the user resumes a build (MNG-4660), they could see a message "Packaged artifact is not up-to-date compared to the build output directory". This could even be logged multiple times for one build. It was unclear why it was logged and what a user could do to address it. This change adds a little bit of detail to that message so it becomes more clear to the user what has happened and where to look for solutions.
The integration test is updated as well.
ICLA and CCLA signed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] rfscholte commented on a change in pull request #414: [MNG-4660] Increase usefulness of logging
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #414:
URL: https://github.com/apache/maven/pull/414#discussion_r548026211
##########
File path: maven-core/src/main/java/org/apache/maven/ReactorReader.java
##########
@@ -266,7 +266,12 @@ private boolean isPackagedArtifactUpToDate( MavenProject project, File packagedA
long outputFileLastModified = Files.getLastModifiedTime( outputFile ).toMillis();
if ( outputFileLastModified > artifactLastModified )
{
- logger.warn( "Packaged artifact is not up-to-date compared to the build output directory" );
+ LOGGER.warn(
+ "Packaged artifact for {} is not up-to-date compared to the build output directory; "
Review comment:
One other thing I was missing is: which one is used?
Could this be compressed to something like:
For ARTIFACTID the jar is older than o.a.m.some.File.class: using target/classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] mthmulders commented on pull request #414: [MNG-4660] Increase usefulness of logging
Posted by GitBox <gi...@apache.org>.
mthmulders commented on pull request #414:
URL: https://github.com/apache/maven/pull/414#issuecomment-750357666
Merged in 7e21a52.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] mthmulders closed pull request #414: [MNG-4660] Increase usefulness of logging
Posted by GitBox <gi...@apache.org>.
mthmulders closed pull request #414:
URL: https://github.com/apache/maven/pull/414
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] mthmulders commented on a change in pull request #414: [MNG-4660] Increase usefulness of logging
Posted by GitBox <gi...@apache.org>.
mthmulders commented on a change in pull request #414:
URL: https://github.com/apache/maven/pull/414#discussion_r548119367
##########
File path: maven-core/src/main/java/org/apache/maven/ReactorReader.java
##########
@@ -266,7 +266,12 @@ private boolean isPackagedArtifactUpToDate( MavenProject project, File packagedA
long outputFileLastModified = Files.getLastModifiedTime( outputFile ).toMillis();
if ( outputFileLastModified > artifactLastModified )
{
- logger.warn( "Packaged artifact is not up-to-date compared to the build output directory" );
+ LOGGER.warn(
+ "Packaged artifact for {} is not up-to-date compared to the build output directory; "
Review comment:
Since this PR is already merged, I've created a follow-up where we can discuss the actual message: https://github.com/apache/maven/pull/416.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org