[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #7509: Support grouped dynamic configurations in DCS and add zookeeper implementation

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #7509:
URL: https://github.com/apache/skywalking/pull/7509#discussion_r692726947



##########
File path: oap-server/server-configuration/configuration-api/src/main/java/org/apache/skywalking/oap/server/configuration/api/ConfigWatcherRegister.java
##########
@@ -110,6 +110,67 @@ void configSync() {
 
             LOGGER.trace("Current configurations after the sync." + LINE_SEPARATOR + register.toString());
         });
+
+        GroupConfigsSync(configTable);
+    }
+
+    private void GroupConfigsSync(Optional<ConfigTable> configTable) {
+        configTable.ifPresent(config -> {

Review comment:
       Try to reduce the nested levels
   
   ```suggestion
           configTable.ifPresent(this::groupConfigsSync);
       }
   
       private void groupConfigsSync(ConfigTable config) {
   ```
   
   Also the first letter should be lowercase 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org