[GitHub] [kafka] rondagostino commented on a diff in pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

["rondagostino (via GitHub)" <gi...@apache.org>]

rondagostino commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1097911296


##########
core/src/main/scala/kafka/server/ControllerApis.scala:
##########
@@ -322,15 +325,37 @@ class ControllerApis(val requestChannel: RequestChannel,
           }
         }
         // Finally, the idToName map contains all the topics that we are authorized to delete.
-        // Perform the deletion and create responses for each one.
-        controller.deleteTopics(context, idToName.keySet).thenApply { idToError =>
-          idToError.forEach { (id, error) =>
-            appendResponse(idToName.get(id), id, error)
+        // First check the controller mutation quota if necessary, and then

Review Comment:
   I believe these locks are scoped by the controller mutation quota manager such that nobody else would contest for them aside from the single-threaded controller.  @dajac might you be able to confirm this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org