You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Phabricator (JIRA)" <ji...@apache.org> on 2013/08/01 00:27:48 UTC
[jira] [Commented] (HIVE-4960) lastAlias in CommonJoinOperator is
not used
[ https://issues.apache.org/jira/browse/HIVE-4960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13725787#comment-13725787 ]
Phabricator commented on HIVE-4960:
-----------------------------------
ashutoshc has accepted the revision "HIVE-4960 [jira] lastAlias in CommonJoinOperator is not used".
+1
REVISION DETAIL
https://reviews.facebook.net/D11895
BRANCH
HIVE-4960
ARCANIST PROJECT
hive
To: JIRA, ashutoshc, yhuai
> lastAlias in CommonJoinOperator is not used
> -------------------------------------------
>
> Key: HIVE-4960
> URL: https://issues.apache.org/jira/browse/HIVE-4960
> Project: Hive
> Issue Type: Improvement
> Reporter: Yin Huai
> Assignee: Yin Huai
> Priority: Minor
> Attachments: HIVE-4960.D11895.1.patch
>
>
> In CommonJoinOperator, there is object called lastAlias. The initial value of this object is 'null'. After tracing the usage of this object, I found that there is no place to change the value of this object. Also, it is only used in processOp in JoinOperator and MapJoinOperator as
> {code}
> if ((lastAlias == null) || (!lastAlias.equals(alias))) {
> nextSz = joinEmitInterval;
> }
> {\code}
> Since lastAlias will always be null, we will assign joinEmitInterval to nextSz every time we get a row. Later in processOp, we have
> {code}
> nextSz = getNextSize(nextSz);
> {\code}
> Because we reset the value of nextSz to joinEmitInterval every time we get a row, seems that getNextSize will not be used as expected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira