[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #5692: Use `curl` to download the MaxMind database, not `wget`

[GitBox <gi...@apache.org>]

zrhoffman commented on a change in pull request #5692:
URL: https://github.com/apache/trafficcontrol/pull/5692#discussion_r604345479



##########
File path: traffic_ops/install/bin/_postinstall
##########
@@ -711,10 +711,10 @@ def unmarshal_config(dct): # type: (dict) -> dict[str, list[Question]]
 
 	return ret
 
-def setup_maxmind(maxmind_answer, root): # type: (str, str) -> None
+def setup_maxmind(maxmind_answer, root, download_tool = '/usr/bin/curl'): # type: (str, str, str) -> None

Review comment:
       The OSes that this project officially supports are CentOS 7 and CentOS 8. Neither OS includes `wget` by default and both include `curl` by default, so I consider the old tool using `wget` instead of `curl` a bug by itself.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org