[GitHub] [pulsar] codelipenghui commented on a diff in pull request #17852: [branch-2.9] Group prometheus metrics.

[GitBox <gi...@apache.org>]

codelipenghui commented on code in PR #17852:
URL: https://github.com/apache/pulsar/pull/17852#discussion_r981854169


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsGenerator.java:
##########
@@ -129,6 +135,8 @@ public static void generate(PulsarService pulsar, boolean includeTopicMetrics, b
             }
             out.write(buf.array(), buf.arrayOffset(), buf.readableBytes());
         } finally {
+            //release all the metrics buffers
+            metricStreams.releaseAll();

Review Comment:
   @tjiuming I noticed you had removed the `exceptionHappens`, if we don't have the check, will we release the `buf` multiple times?
   
   From the master branch:
   
   ```
   } catch (Throwable t) {
               exceptionHappens = true;
               throw t;
           } finally {
               //release all the metrics buffers
               metricStreams.releaseAll();
               //if exception happens, release buffer
               if (exceptionHappens) {
                   buf.release();
               }
           }
   ```
   
   And it looks like we will also cherry-pick https://github.com/apache/pulsar/pull/14453 to branch-2.9?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org