You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/09/15 17:55:05 UTC
[GitHub] [trafficserver] shinrich opened a new pull request #7194: Remove unused HttpUpdate mechanism
shinrich opened a new pull request #7194:
URL: https://github.com/apache/trafficserver/pull/7194
It appears that the HttpUpdateSM is only called from the HttpUpdateTester. And the HttpUpdateTester is only invoked when traffic_server is started with the http_update_test action tag. In addition, the test only does things if there is a file called "urls" in the current directory of the traffic_server process.
I assume this is an old testing infrastructure that is no longer used. autest should be used to exercise requests against traffic server.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #7194: Remove unused HttpUpdate mechanism
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #7194:
URL: https://github.com/apache/trafficserver/pull/7194#issuecomment-693493710
Yes. Better to file distinct clean ups separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich merged pull request #7194: Remove unused HttpUpdate mechanism
Posted by GitBox <gi...@apache.org>.
shinrich merged pull request #7194:
URL: https://github.com/apache/trafficserver/pull/7194
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7194: Remove unused HttpUpdate mechanism
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7194:
URL: https://github.com/apache/trafficserver/pull/7194#issuecomment-693014617
If you prefer go ahead and merge this as is and I'll create a 2nd PR that whacks out the kill_this_async_hook().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7194: Remove unused HttpUpdate mechanism
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7194:
URL: https://github.com/apache/trafficserver/pull/7194#issuecomment-692910312
As you KWF this kruft, it looks like the controlled burn should also include the HttpSM members kill_this_async_done and kill_this_sync_hook. ( https://github.com/apache/trafficserver/blob/39c7be57e453fe92b20f769d7b9a70f1d21d2ece/proxy/http/HttpSM.h#L594 ) They've been scaring me for years, make it stop!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on pull request #7194: Remove unused HttpUpdate mechanism
Posted by GitBox <gi...@apache.org>.
ywkaras commented on pull request #7194:
URL: https://github.com/apache/trafficserver/pull/7194#issuecomment-693013472
It looks potentially risky to remove kill_this_async_done. But kill_this_async_hook is ONLY overridden by HttpUpdateSM. When HttpUpdateSM is removed, it just obfuscates to keep kill_this_async_hook. The last think the state machine needs is more obfuscation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shinrich commented on pull request #7194: Remove unused HttpUpdate mechanism
Posted by GitBox <gi...@apache.org>.
shinrich commented on pull request #7194:
URL: https://github.com/apache/trafficserver/pull/7194#issuecomment-693006457
Yeah, kill_this is a two phase thing that I don't fully understand.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org