You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/25 15:50:06 UTC

[GitHub] [airflow] potiuk opened a new pull request, #24656: Handle "workflow_run" event properly in selective-check

potiuk opened a new pull request, #24656:
URL: https://github.com/apache/airflow/pull/24656

   Unfortunately testing workflow_run is a bit difficult because
   the changes are only effective after merging them.
   
   Fixing (hopefully) yet another mistake in the workflow run where
   commit hash was passed as event name (?)
   
   We are going to handle "workflow_run" as valid event type so this
   should now work without passing any event.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #24656: Handle "workflow_run" event properly in selective-check

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24656:
URL: https://github.com/apache/airflow/pull/24656#issuecomment-1166346763

   Needs #24659 merged to succeed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] mik-laj merged pull request #24656: Handle "workflow_run" event properly in selective-check

Posted by GitBox <gi...@apache.org>.
mik-laj merged PR #24656:
URL: https://github.com/apache/airflow/pull/24656


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org