You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xianglyc (via GitHub)" <gi...@apache.org> on 2026/01/14 06:33:28 UTC
[PR] arch/x64: create qemu chip [nuttx]
xianglyc opened a new pull request, #17881:
URL: https://github.com/apache/nuttx/pull/17881
*Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).*
## Summary
create qemu chip
*Update this section with information on why change is necessary,
what it exactly does and how, if new feature shows up, provide
references (dependencies, similar problems and solutions), etc.*
ostest
## Impact
no
*Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.*
## Testing
*This section should provide a detailed description of what you did
to verify your changes work and do not break existing code.*
*Please provide information about your host machine, the board(s) you
tested your changes on, and how you tested. Logs should be included.*
*For example, when changing something in the core OS functions, you
may want to run the OSTest application to verify that there are no
regressions. Changes to ADC code may warrant running the `adc`
example. Adding a new uORB driver may require that you run
`uorb_listener` to verify correct operation.*
*Pure documentation changes can just be tested with `make html`
(see docs) and verification of the correct format in your
browser.*
**_PRs without testing information will not be accepted. We will
request test logs._**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/x64: create qemu chip [nuttx]
Posted by "xianglyc (via GitHub)" <gi...@apache.org>.
xianglyc commented on code in PR #17881:
URL: https://github.com/apache/nuttx/pull/17881#discussion_r2702556704
##########
arch/x86_64/Kconfig:
##########
@@ -43,14 +35,34 @@ config ARCH_INTEL64
---help---
Intel x86_64 architecture
+choice
+ prompt "x86_64 chip selection"
+ default ARCH_CHIP_INTEL64_QEMU
+
+config ARCH_CHIP_INTEL64_QEMU
+ bool "qemu x86_64 chip"
Review Comment:
>
done
##########
arch/x86_64/Kconfig:
##########
@@ -43,14 +35,34 @@ config ARCH_INTEL64
---help---
Intel x86_64 architecture
+choice
+ prompt "x86_64 chip selection"
+ default ARCH_CHIP_INTEL64_QEMU
+
+config ARCH_CHIP_INTEL64_QEMU
+ bool "qemu x86_64 chip"
+ select ARCH_INTEL64
+ ---help---
+ Select this option if the platform is QEMU.
Review Comment:
done
##########
arch/x86_64/Kconfig:
##########
@@ -43,14 +35,34 @@ config ARCH_INTEL64
---help---
Intel x86_64 architecture
+choice
+ prompt "x86_64 chip selection"
+ default ARCH_CHIP_INTEL64_QEMU
+
+config ARCH_CHIP_INTEL64_QEMU
+ bool "qemu x86_64 chip"
+ select ARCH_INTEL64
+ ---help---
+ Select this option if the platform is QEMU.
+
+config ARCH_CHIP_INTEL64
+ bool "intel64 x86_64 chip"
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/x64: create qemu chip [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #17881:
URL: https://github.com/apache/nuttx/pull/17881#discussion_r2695701734
##########
arch/x86_64/Kconfig:
##########
@@ -43,14 +35,34 @@ config ARCH_INTEL64
---help---
Intel x86_64 architecture
+choice
+ prompt "x86_64 chip selection"
+ default ARCH_CHIP_INTEL64_QEMU
+
+config ARCH_CHIP_INTEL64_QEMU
+ bool "qemu x86_64 chip"
Review Comment:
```suggestion
bool "QEMU x86_64 chip"
##########
arch/x86_64/Kconfig:
##########
@@ -43,14 +35,34 @@ config ARCH_INTEL64
---help---
Intel x86_64 architecture
+choice
+ prompt "x86_64 chip selection"
+ default ARCH_CHIP_INTEL64_QEMU
+
+config ARCH_CHIP_INTEL64_QEMU
+ bool "qemu x86_64 chip"
Review Comment:
QEMU is always upper case, see: https://www.qemu.org/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/x64: create qemu chip [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #17881:
URL: https://github.com/apache/nuttx/pull/17881#discussion_r2695711485
##########
arch/x86_64/Kconfig:
##########
@@ -43,14 +35,34 @@ config ARCH_INTEL64
---help---
Intel x86_64 architecture
+choice
+ prompt "x86_64 chip selection"
+ default ARCH_CHIP_INTEL64_QEMU
+
+config ARCH_CHIP_INTEL64_QEMU
+ bool "qemu x86_64 chip"
+ select ARCH_INTEL64
+ ---help---
+ Select this option if the platform is QEMU.
+
+config ARCH_CHIP_INTEL64
+ bool "intel64 x86_64 chip"
+ select ARCH_INTEL64
+ ---help---
+ Select this option if the platform is Intel64.
Review Comment:
Please improve ---help--- Description
##########
arch/x86_64/Kconfig:
##########
@@ -43,14 +35,34 @@ config ARCH_INTEL64
---help---
Intel x86_64 architecture
+choice
+ prompt "x86_64 chip selection"
+ default ARCH_CHIP_INTEL64_QEMU
+
+config ARCH_CHIP_INTEL64_QEMU
+ bool "qemu x86_64 chip"
+ select ARCH_INTEL64
+ ---help---
+ Select this option if the platform is QEMU.
Review Comment:
Please improve the ---help--- Description. What people needs to know to decide to enable or not this option?
##########
arch/x86_64/Kconfig:
##########
@@ -43,14 +35,34 @@ config ARCH_INTEL64
---help---
Intel x86_64 architecture
+choice
+ prompt "x86_64 chip selection"
+ default ARCH_CHIP_INTEL64_QEMU
+
+config ARCH_CHIP_INTEL64_QEMU
+ bool "qemu x86_64 chip"
+ select ARCH_INTEL64
+ ---help---
+ Select this option if the platform is QEMU.
+
+config ARCH_CHIP_INTEL64
+ bool "intel64 x86_64 chip"
Review Comment:
```suggestion
bool "Intel64 x86_64 chip"
##########
arch/x86_64/Kconfig:
##########
@@ -43,14 +35,34 @@ config ARCH_INTEL64
---help---
Intel x86_64 architecture
+choice
+ prompt "x86_64 chip selection"
+ default ARCH_CHIP_INTEL64_QEMU
+
+config ARCH_CHIP_INTEL64_QEMU
+ bool "qemu x86_64 chip"
+ select ARCH_INTEL64
+ ---help---
+ Select this option if the platform is QEMU.
+
+config ARCH_CHIP_INTEL64
+ bool "intel64 x86_64 chip"
Review Comment:
This is the original name that was in the other Kconfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/x64: create qemu chip [nuttx]
Posted by "xianglyc (via GitHub)" <gi...@apache.org>.
xianglyc commented on code in PR #17881:
URL: https://github.com/apache/nuttx/pull/17881#discussion_r2702556892
##########
arch/x86_64/Kconfig:
##########
@@ -43,14 +35,34 @@ config ARCH_INTEL64
---help---
Intel x86_64 architecture
+choice
+ prompt "x86_64 chip selection"
+ default ARCH_CHIP_INTEL64_QEMU
+
+config ARCH_CHIP_INTEL64_QEMU
+ bool "qemu x86_64 chip"
+ select ARCH_INTEL64
+ ---help---
+ Select this option if the platform is QEMU.
+
+config ARCH_CHIP_INTEL64
+ bool "intel64 x86_64 chip"
+ select ARCH_INTEL64
+ ---help---
+ Select this option if the platform is Intel64.
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/x64: create qemu chip [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #17881:
URL: https://github.com/apache/nuttx/pull/17881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org