You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by cm...@apache.org on 2012/08/24 19:02:25 UTC
svn commit: r1376992 - /subversion/trunk/subversion/libsvn_repos/repos.c
Author: cmpilato
Date: Fri Aug 24 17:02:24 2012
New Revision: 1376992
URL: http://svn.apache.org/viewvc?rev=1376992&view=rev
Log:
* subversion/libsvn_repos/repos.c
(create_hooks): Tweak 'start-commit' template text, grouping the
description of the TXN-NAME arg closer to that of the CAPABILITIES arg.
Modified:
subversion/trunk/subversion/libsvn_repos/repos.c
Modified: subversion/trunk/subversion/libsvn_repos/repos.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_repos/repos.c?rev=1376992&r1=1376991&r2=1376992&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_repos/repos.c (original)
+++ subversion/trunk/subversion/libsvn_repos/repos.c Fri Aug 24 17:02:24 2012
@@ -330,6 +330,11 @@ create_hooks(svn_repos_t *repos, apr_poo
"# e.g.: \"" SVN_RA_CAPABILITY_MERGEINFO ":some-other-capability\" " \
"(the order is undefined)." NL
"#" NL
+"# Note: The TXN-NAME parameter is new in Subversion 1.8. Prior to version" NL
+"# 1.8, the start-commit hook was invoked before the commit txn was even" NL
+"# created, so the ability to inspect the commit txn and its metadata from" NL
+"# within the start-commit hook was not possible." NL
+"# " NL
"# The list is self-reported by the client. Therefore, you should not" NL
"# make security assumptions based on the capabilities list, nor should" NL
"# you assume that clients reliably report every capability they have." NL
@@ -353,10 +358,6 @@ create_hooks(svn_repos_t *repos, apr_poo
"# '"SCRIPT_NAME".bat' or '"SCRIPT_NAME".exe'," NL
"# but the basic idea is the same." NL
"# " NL
-"# COMPATIBILITY NOTE: Prior to Subversion 1.8, the start-commit hook was" NL
-"# invoked before the commit txn was even created, and it did not accept" NL
-"# the TXN-NAME argument at all." NL
-"# " NL
HOOKS_ENVIRONMENT_TEXT
"# " NL
"# Here is an example hook script, for a Unix /bin/sh interpreter." NL
Re: svn commit: r1376992 -
/subversion/trunk/subversion/libsvn_repos/repos.c
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
C. Michael Pilato wrote on Mon, Aug 27, 2012 at 09:13:26 -0400:
> On 08/27/2012 08:45 AM, Daniel Shahaf wrote:
> > cmpilato@apache.org wrote on Fri, Aug 24, 2012 at 17:02:25 -0000:
> >> Author: cmpilato
> >> Date: Fri Aug 24 17:02:24 2012
> >> New Revision: 1376992
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1376992&view=rev
> >> Log:
> >> * subversion/libsvn_repos/repos.c
> >> (create_hooks): Tweak 'start-commit' template text, grouping the
> >> description of the TXN-NAME arg closer to that of the CAPABILITIES arg.
> >>
> >
> > Log message doesn't match the unidiff. (The diff is missing a
> > "-TXN_NAME" block, and there is a "-COMPAT NOTE" block which isn't in
> > the log msg)
>
> Well, in my head it read correctly anyway. :-P
Maybe I didn't read the unidiff carefully enough.
Re: svn commit: r1376992 -
/subversion/trunk/subversion/libsvn_repos/repos.c
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
C. Michael Pilato wrote on Mon, Aug 27, 2012 at 09:13:26 -0400:
> On 08/27/2012 08:45 AM, Daniel Shahaf wrote:
> > cmpilato@apache.org wrote on Fri, Aug 24, 2012 at 17:02:25 -0000:
> >> Author: cmpilato
> >> Date: Fri Aug 24 17:02:24 2012
> >> New Revision: 1376992
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1376992&view=rev
> >> Log:
> >> * subversion/libsvn_repos/repos.c
> >> (create_hooks): Tweak 'start-commit' template text, grouping the
> >> description of the TXN-NAME arg closer to that of the CAPABILITIES arg.
> >>
> >
> > Log message doesn't match the unidiff. (The diff is missing a
> > "-TXN_NAME" block, and there is a "-COMPAT NOTE" block which isn't in
> > the log msg)
>
> Well, in my head it read correctly anyway. :-P
Maybe I didn't read the unidiff carefully enough.
Re: svn commit: r1376992 - /subversion/trunk/subversion/libsvn_repos/repos.c
Posted by "C. Michael Pilato" <cm...@collab.net>.
On 08/27/2012 08:45 AM, Daniel Shahaf wrote:
> cmpilato@apache.org wrote on Fri, Aug 24, 2012 at 17:02:25 -0000:
>> Author: cmpilato
>> Date: Fri Aug 24 17:02:24 2012
>> New Revision: 1376992
>>
>> URL: http://svn.apache.org/viewvc?rev=1376992&view=rev
>> Log:
>> * subversion/libsvn_repos/repos.c
>> (create_hooks): Tweak 'start-commit' template text, grouping the
>> description of the TXN-NAME arg closer to that of the CAPABILITIES arg.
>>
>
> Log message doesn't match the unidiff. (The diff is missing a
> "-TXN_NAME" block, and there is a "-COMPAT NOTE" block which isn't in
> the log msg)
Well, in my head it read correctly anyway. :-P
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Enterprise Cloud Development
Re: svn commit: r1376992 - /subversion/trunk/subversion/libsvn_repos/repos.c
Posted by "C. Michael Pilato" <cm...@collab.net>.
On 08/27/2012 08:45 AM, Daniel Shahaf wrote:
> cmpilato@apache.org wrote on Fri, Aug 24, 2012 at 17:02:25 -0000:
>> Author: cmpilato
>> Date: Fri Aug 24 17:02:24 2012
>> New Revision: 1376992
>>
>> URL: http://svn.apache.org/viewvc?rev=1376992&view=rev
>> Log:
>> * subversion/libsvn_repos/repos.c
>> (create_hooks): Tweak 'start-commit' template text, grouping the
>> description of the TXN-NAME arg closer to that of the CAPABILITIES arg.
>>
>
> Log message doesn't match the unidiff. (The diff is missing a
> "-TXN_NAME" block, and there is a "-COMPAT NOTE" block which isn't in
> the log msg)
Well, in my head it read correctly anyway. :-P
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Enterprise Cloud Development
Re: svn commit: r1376992 -
/subversion/trunk/subversion/libsvn_repos/repos.c
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
cmpilato@apache.org wrote on Fri, Aug 24, 2012 at 17:02:25 -0000:
> Author: cmpilato
> Date: Fri Aug 24 17:02:24 2012
> New Revision: 1376992
>
> URL: http://svn.apache.org/viewvc?rev=1376992&view=rev
> Log:
> * subversion/libsvn_repos/repos.c
> (create_hooks): Tweak 'start-commit' template text, grouping the
> description of the TXN-NAME arg closer to that of the CAPABILITIES arg.
>
Log message doesn't match the unidiff. (The diff is missing a
"-TXN_NAME" block, and there is a "-COMPAT NOTE" block which isn't in
the log msg)
> Modified:
> subversion/trunk/subversion/libsvn_repos/repos.c
>
> Modified: subversion/trunk/subversion/libsvn_repos/repos.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_repos/repos.c?rev=1376992&r1=1376991&r2=1376992&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/libsvn_repos/repos.c (original)
> +++ subversion/trunk/subversion/libsvn_repos/repos.c Fri Aug 24 17:02:24 2012
> @@ -330,6 +330,11 @@ create_hooks(svn_repos_t *repos, apr_poo
> "# e.g.: \"" SVN_RA_CAPABILITY_MERGEINFO ":some-other-capability\" " \
> "(the order is undefined)." NL
> "#" NL
> +"# Note: The TXN-NAME parameter is new in Subversion 1.8. Prior to version" NL
> +"# 1.8, the start-commit hook was invoked before the commit txn was even" NL
> +"# created, so the ability to inspect the commit txn and its metadata from" NL
> +"# within the start-commit hook was not possible." NL
> +"# " NL
> "# The list is self-reported by the client. Therefore, you should not" NL
> "# make security assumptions based on the capabilities list, nor should" NL
> "# you assume that clients reliably report every capability they have." NL
> @@ -353,10 +358,6 @@ create_hooks(svn_repos_t *repos, apr_poo
> "# '"SCRIPT_NAME".bat' or '"SCRIPT_NAME".exe'," NL
> "# but the basic idea is the same." NL
> "# " NL
> -"# COMPATIBILITY NOTE: Prior to Subversion 1.8, the start-commit hook was" NL
> -"# invoked before the commit txn was even created, and it did not accept" NL
> -"# the TXN-NAME argument at all." NL
> -"# " NL
> HOOKS_ENVIRONMENT_TEXT
> "# " NL
> "# Here is an example hook script, for a Unix /bin/sh interpreter." NL
>
>
Re: svn commit: r1376992 -
/subversion/trunk/subversion/libsvn_repos/repos.c
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
cmpilato@apache.org wrote on Fri, Aug 24, 2012 at 17:02:25 -0000:
> Author: cmpilato
> Date: Fri Aug 24 17:02:24 2012
> New Revision: 1376992
>
> URL: http://svn.apache.org/viewvc?rev=1376992&view=rev
> Log:
> * subversion/libsvn_repos/repos.c
> (create_hooks): Tweak 'start-commit' template text, grouping the
> description of the TXN-NAME arg closer to that of the CAPABILITIES arg.
>
Log message doesn't match the unidiff. (The diff is missing a
"-TXN_NAME" block, and there is a "-COMPAT NOTE" block which isn't in
the log msg)
> Modified:
> subversion/trunk/subversion/libsvn_repos/repos.c
>
> Modified: subversion/trunk/subversion/libsvn_repos/repos.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_repos/repos.c?rev=1376992&r1=1376991&r2=1376992&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/libsvn_repos/repos.c (original)
> +++ subversion/trunk/subversion/libsvn_repos/repos.c Fri Aug 24 17:02:24 2012
> @@ -330,6 +330,11 @@ create_hooks(svn_repos_t *repos, apr_poo
> "# e.g.: \"" SVN_RA_CAPABILITY_MERGEINFO ":some-other-capability\" " \
> "(the order is undefined)." NL
> "#" NL
> +"# Note: The TXN-NAME parameter is new in Subversion 1.8. Prior to version" NL
> +"# 1.8, the start-commit hook was invoked before the commit txn was even" NL
> +"# created, so the ability to inspect the commit txn and its metadata from" NL
> +"# within the start-commit hook was not possible." NL
> +"# " NL
> "# The list is self-reported by the client. Therefore, you should not" NL
> "# make security assumptions based on the capabilities list, nor should" NL
> "# you assume that clients reliably report every capability they have." NL
> @@ -353,10 +358,6 @@ create_hooks(svn_repos_t *repos, apr_poo
> "# '"SCRIPT_NAME".bat' or '"SCRIPT_NAME".exe'," NL
> "# but the basic idea is the same." NL
> "# " NL
> -"# COMPATIBILITY NOTE: Prior to Subversion 1.8, the start-commit hook was" NL
> -"# invoked before the commit txn was even created, and it did not accept" NL
> -"# the TXN-NAME argument at all." NL
> -"# " NL
> HOOKS_ENVIRONMENT_TEXT
> "# " NL
> "# Here is an example hook script, for a Unix /bin/sh interpreter." NL
>
>