You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/12 12:20:05 UTC

[GitHub] [incubator-nuttx] jlaitine commented on a diff in pull request #6010: env_dup: fix copying of parent's env to child with ARCH_ADDRENV=y

jlaitine commented on code in PR #6010:
URL: https://github.com/apache/incubator-nuttx/pull/6010#discussion_r848369680


##########
sched/environ/env_dup.c:
##########
@@ -61,14 +63,13 @@
  *
  ****************************************************************************/
 
-int env_dup(FAR struct task_group_s *group)
+int env_dup(FAR struct task_group_s *group, FAR char * const *envp,

Review Comment:
   This is a bugfix; the original bug causes a full system crash and I need this as well.
   
   I think it is reasonable to integrate the bugfix and do the refactoring later, if needed.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org