You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/10/08 15:28:23 UTC
[GitHub] [incubator-seatunnel] liugddx opened a new pull request, #3026: [Feature][Connector-V2][Jdbc] support gbase 8a
liugddx opened a new pull request, #3026:
URL: https://github.com/apache/incubator-seatunnel/pull/3026
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #3026: [Feature][Connector-V2][Jdbc] support gbase 8a
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #3026:
URL: https://github.com/apache/incubator-seatunnel/pull/3026#issuecomment-1275667481
Hold on,i'm fixing it.
Best Regards
liugddx
***@***.***
------------------ Original ------------------
From: ***@***.***>;
Date: 2022年10月12日(星期三) 下午2:34
To: ***@***.***>;
Cc: ***@***.***>; ***@***.***>;
Subject: Re: [apache/incubator-seatunnel] [Feature][Connector-V2][Jdbc] support gbase 8a (PR #3026)
please fix ci error
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #3026: [Feature][Connector-V2][Jdbc] support gbase 8a
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #3026:
URL: https://github.com/apache/incubator-seatunnel/pull/3026#issuecomment-1274405439
gbase8a must use sql date `java.sql.Date`,`java.sql.Time`,`java.sql.Timestamp`,otherwise it will be abnormal.
```
Exception in thread "main" com.gbase.jdbc.GBaseDataTruncation: Data truncation: Incorrect date value: '******'
at com.gbase.jdbc.GBaseIO.checkErrorPacket(GBaseIO.java:3631)
at com.gbase.jdbc.GBaseIO.checkErrorPacket(GBaseIO.java:3565)
at com.gbase.jdbc.GBaseIO.sendCommand(GBaseIO.java:1996)
at com.gbase.jdbc.GBaseIO.sqlQueryDirect(GBaseIO.java:2150)
at com.gbase.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2652)
at com.gbase.jdbc.PreparedStatement.executeInternal(PreparedStatement.java:2133)
at com.gbase.jdbc.PreparedStatement.executeUpdate(PreparedStatement.java:2429)
at com.gbase.jdbc.PreparedStatement.executeUpdate(PreparedStatement.java:2347)
at com.gbase.jdbc.PreparedStatement.executeUpdate(PreparedStatement.java:2332)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #3026: [Feature][Connector-V2][Jdbc] support gbase 8a
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #3026:
URL: https://github.com/apache/incubator-seatunnel/pull/3026#issuecomment-1282143735
Why we need add `SqlDateType`? It's same with `LocalTimeType`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #3026: [Feature][Connector-V2][Jdbc] support gbase 8a
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #3026:
URL: https://github.com/apache/incubator-seatunnel/pull/3026#issuecomment-1274385558
please run CI @EricJoy2048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #3026: [Feature][Connector-V2][Jdbc] support gbase 8a
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #3026:
URL: https://github.com/apache/incubator-seatunnel/pull/3026#issuecomment-1279730933
Rerun CI and help to review thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #3026: [Feature][Connector-V2][Jdbc] support gbase 8a
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on code in PR #3026:
URL: https://github.com/apache/incubator-seatunnel/pull/3026#discussion_r996448067
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/gbase8a/Gbase8aJdbcRowConverter.java:
##########
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.gbase8a;
+
+import org.apache.seatunnel.api.table.type.SeaTunnelDataType;
+import org.apache.seatunnel.api.table.type.SeaTunnelRow;
+import org.apache.seatunnel.api.table.type.SeaTunnelRowType;
+import org.apache.seatunnel.api.table.type.SqlType;
+import org.apache.seatunnel.connectors.seatunnel.jdbc.internal.converter.AbstractJdbcRowConverter;
+
+import java.math.BigDecimal;
+import java.math.BigInteger;
+import java.sql.ResultSet;
+import java.sql.ResultSetMetaData;
+import java.sql.SQLException;
+import java.util.ArrayList;
+import java.util.List;
+
+public class Gbase8aJdbcRowConverter extends AbstractJdbcRowConverter {
+ @Override
+ public String converterName() {
+ return "Gbase8a";
+ }
+
+ @SuppressWarnings("checkstyle:MagicNumber")
+ @Override
+ public SeaTunnelRow toInternal(ResultSet rs, ResultSetMetaData metaData, SeaTunnelRowType typeInfo) throws SQLException {
+ List<Object> fields = new ArrayList<>(16);
Review Comment:
```suggestion
List<Object> fields = new ArrayList<>(typeInfo.getFieldTypes().length);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #3026: [Feature][Connector-V2][Jdbc] support gbase 8a
Posted by GitBox <gi...@apache.org>.
ashulin commented on code in PR #3026:
URL: https://github.com/apache/incubator-seatunnel/pull/3026#discussion_r997999016
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SqlDateType.java:
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.api.table.type;
+
+import java.sql.Date;
+import java.sql.Time;
+import java.sql.Timestamp;
+import java.util.Objects;
+
+public class SqlDateType<T> implements SeaTunnelDataType<T> {
Review Comment:
IMO, this is not necessary.
The same effect can be achieved using LocalTimeType.
Multiple time types can confuse developers/users
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #3026: [Feature][Connector-V2][Jdbc] support gbase 8a
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #3026:
URL: https://github.com/apache/incubator-seatunnel/pull/3026#issuecomment-1282310213
Gbase8a test is ok,however, the sink does not support `localTimeType ` type.Now I'm using the `Assert` test results . @EricJoy2048 @Hisoka-X @ashulin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on pull request #3026: [Feature][Connector-V2][Jdbc] support gbase 8a
Posted by GitBox <gi...@apache.org>.
hailin0 commented on PR #3026:
URL: https://github.com/apache/incubator-seatunnel/pull/3026#issuecomment-1275661320
please fix ci error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #3026: [Feature][Connector-V2][Jdbc] support gbase 8a
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on code in PR #3026:
URL: https://github.com/apache/incubator-seatunnel/pull/3026#discussion_r997995162
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SqlDateType.java:
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.api.table.type;
+
+import java.sql.Date;
+import java.sql.Time;
+import java.sql.Timestamp;
+import java.util.Objects;
+
+public class SqlDateType<T> implements SeaTunnelDataType<T> {
Review Comment:
@ashulin PTAL about add new `SqlDateType`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 merged pull request #3026: [Feature][Connector-V2][Jdbc] support gbase 8a
Posted by GitBox <gi...@apache.org>.
EricJoy2048 merged PR #3026:
URL: https://github.com/apache/incubator-seatunnel/pull/3026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #3026: [Feature][Connector-V2][Jdbc] support gbase 8a
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on code in PR #3026:
URL: https://github.com/apache/incubator-seatunnel/pull/3026#discussion_r994677201
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/gbase8a/Gbase8aJdbcRowConverter.java:
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.gbase8a;
+
+import org.apache.seatunnel.api.table.type.BasicType;
+import org.apache.seatunnel.api.table.type.DecimalType;
+import org.apache.seatunnel.api.table.type.PrimitiveByteArrayType;
+import org.apache.seatunnel.api.table.type.SeaTunnelDataType;
+import org.apache.seatunnel.api.table.type.SeaTunnelRow;
+import org.apache.seatunnel.api.table.type.SeaTunnelRowType;
+import org.apache.seatunnel.api.table.type.SqlDateType;
+import org.apache.seatunnel.connectors.seatunnel.jdbc.internal.converter.AbstractJdbcRowConverter;
+
+import java.math.BigDecimal;
+import java.math.BigInteger;
+import java.sql.ResultSet;
+import java.sql.ResultSetMetaData;
+import java.sql.SQLException;
+import java.util.ArrayList;
+import java.util.List;
+
+public class Gbase8aJdbcRowConverter extends AbstractJdbcRowConverter {
+ @Override
+ public String converterName() {
+ return "Gbase8a";
+ }
+
+ @Override
+ public SeaTunnelRow toInternal(ResultSet rs, ResultSetMetaData metaData, SeaTunnelRowType typeInfo) throws SQLException {
+ List<Object> fields = new ArrayList<>();
Review Comment:
gave a init length is better.
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/oracle/OracleTypeMapper.java:
##########
@@ -75,12 +75,9 @@ public SeaTunnelDataType<?> mapping(ResultSetMetaData metadata, int colIndex) th
switch (oracleType) {
case ORACLE_INTEGER:
return BasicType.INT_TYPE;
+ case ORACLE_FLOAT:
case ORACLE_NUMBER:
- if (precision < 38) {
- return new DecimalType(precision, scale);
- }
Review Comment:
can you add a comment about why delete this?
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/gbase8a/Gbase8aJdbcRowConverter.java:
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.connectors.seatunnel.jdbc.internal.dialect.gbase8a;
+
+import org.apache.seatunnel.api.table.type.BasicType;
+import org.apache.seatunnel.api.table.type.DecimalType;
+import org.apache.seatunnel.api.table.type.PrimitiveByteArrayType;
+import org.apache.seatunnel.api.table.type.SeaTunnelDataType;
+import org.apache.seatunnel.api.table.type.SeaTunnelRow;
+import org.apache.seatunnel.api.table.type.SeaTunnelRowType;
+import org.apache.seatunnel.api.table.type.SqlDateType;
+import org.apache.seatunnel.connectors.seatunnel.jdbc.internal.converter.AbstractJdbcRowConverter;
+
+import java.math.BigDecimal;
+import java.math.BigInteger;
+import java.sql.ResultSet;
+import java.sql.ResultSetMetaData;
+import java.sql.SQLException;
+import java.util.ArrayList;
+import java.util.List;
+
+public class Gbase8aJdbcRowConverter extends AbstractJdbcRowConverter {
+ @Override
+ public String converterName() {
+ return "Gbase8a";
+ }
+
+ @Override
+ public SeaTunnelRow toInternal(ResultSet rs, ResultSetMetaData metaData, SeaTunnelRowType typeInfo) throws SQLException {
+ List<Object> fields = new ArrayList<>();
+ SeaTunnelDataType<?>[] seaTunnelDataTypes = typeInfo.getFieldTypes();
+
+ for (int i = 1; i <= seaTunnelDataTypes.length; i++) {
+ Object seatunnelField;
+ SeaTunnelDataType<?> seaTunnelDataType = seaTunnelDataTypes[i - 1];
Review Comment:
use seaTunnelDataType.getSqlType() is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #3026: [Feature][Connector-V2][Jdbc] support gbase 8a
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #3026:
URL: https://github.com/apache/incubator-seatunnel/pull/3026#issuecomment-1282177110
> Why we need add `SqlDateType`? It's same with `LocalTimeType`.
> gbase8a must use sql date `java.sql.Date`,`java.sql.Time`,`java.sql.Timestamp`,otherwise it will be abnormal.
>
> ```
> Exception in thread "main" com.gbase.jdbc.GBaseDataTruncation: Data truncation: Incorrect date value: '******'
> at com.gbase.jdbc.GBaseIO.checkErrorPacket(GBaseIO.java:3631)
> at com.gbase.jdbc.GBaseIO.checkErrorPacket(GBaseIO.java:3565)
> at com.gbase.jdbc.GBaseIO.sendCommand(GBaseIO.java:1996)
> at com.gbase.jdbc.GBaseIO.sqlQueryDirect(GBaseIO.java:2150)
> at com.gbase.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2652)
> at com.gbase.jdbc.PreparedStatement.executeInternal(PreparedStatement.java:2133)
> at com.gbase.jdbc.PreparedStatement.executeUpdate(PreparedStatement.java:2429)
> at com.gbase.jdbc.PreparedStatement.executeUpdate(PreparedStatement.java:2347)
> at com.gbase.jdbc.PreparedStatement.executeUpdate(PreparedStatement.java:2332)
> ```
@ashulin @Hisoka-X Gbase does not support `localTimeType` type and i don't know what better way to do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #3026: [Feature][Connector-V2][Jdbc] support gbase 8a
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #3026:
URL: https://github.com/apache/incubator-seatunnel/pull/3026#issuecomment-1279755073
rerun CI and help to review thanks. @CalvinKirs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #3026: [Feature][Connector-V2][Jdbc] support gbase 8a
Posted by GitBox <gi...@apache.org>.
ashulin commented on code in PR #3026:
URL: https://github.com/apache/incubator-seatunnel/pull/3026#discussion_r997999016
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SqlDateType.java:
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.api.table.type;
+
+import java.sql.Date;
+import java.sql.Time;
+import java.sql.Timestamp;
+import java.util.Objects;
+
+public class SqlDateType<T> implements SeaTunnelDataType<T> {
Review Comment:
IMO, this is not necessary.
The same effect can be achieved using `LocalTimeType`.
Multiple time types can confuse developers/users
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #3026: [Feature][Connector-V2][Jdbc] support gbase 8a
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #3026:
URL: https://github.com/apache/incubator-seatunnel/pull/3026#issuecomment-1283326012
The CI not passed, please check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #3026: [Feature][Connector-V2][Jdbc] support gbase 8a
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #3026:
URL: https://github.com/apache/incubator-seatunnel/pull/3026#issuecomment-1283468748
> The CI not passed, please check
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #3026: [Feature][Connector-V2][Jdbc] support gbase 8a
Posted by GitBox <gi...@apache.org>.
liugddx commented on PR #3026:
URL: https://github.com/apache/incubator-seatunnel/pull/3026#issuecomment-1278965251
@EricJoy2048 @Hisoka-X @hailin0 please code review,thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org