You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2016/07/29 10:48:33 UTC
Review Request 50603: LENS-1242 : Fix JDBCDriver cancel query to call
statement.cancel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50603/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1242
https://issues.apache.org/jira/browse/LENS-1242
Repository: lens
Description
-------
- Updated JDBCDriver cancel to call statement.cancel
- At JDBCDriver level we can configure if statement.cancel is supported or not. If set to false, it wont be called.
- Extened cancel test actually run a long running query and cancel it.
Diffs
-----
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 8047302
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java ac0682d
lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 66645b9
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 491aa69
lens-driver-jdbc/src/test/resources/drivers/jdbc/jdbc1/jdbcdriver-site.xml 1202074
src/site/apt/admin/jdbcdriver-config.apt 96c98ad
Diff: https://reviews.apache.org/r/50603/diff/
Testing
-------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 50603: LENS-1242 : Fix JDBCDriver cancel query to
call statement.cancel
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50603/#review144083
-----------------------------------------------------------
Ship it!
Ship It!
- Puneet Gupta
On July 29, 2016, 11:26 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50603/
> -----------------------------------------------------------
>
> (Updated July 29, 2016, 11:26 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1242
> https://issues.apache.org/jira/browse/LENS-1242
>
>
> Repository: lens
>
>
> Description
> -------
>
> - Updated JDBCDriver cancel to call statement.cancel
> - At JDBCDriver level we can configure if statement.cancel is supported or not. If set to false, it wont be called.
> - Extened cancel test actually run a long running query and cancel it.
>
>
> Diffs
> -----
>
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 8047302
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java ac0682d
> lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 66645b9
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 491aa69
> lens-driver-jdbc/src/test/resources/drivers/jdbc/jdbc1/jdbcdriver-site.xml 1202074
> src/site/apt/admin/jdbcdriver-config.apt 96c98ad
>
> Diff: https://reviews.apache.org/r/50603/diff/
>
>
> Testing
> -------
>
> Here are the test times in millis:
> testCancelQuery(true) org.apache.lens.driver.jdbc.TestJdbcDriver 185
> testCancelQuery(false) org.apache.lens.driver.jdbc.TestJdbcDriver 52
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 50603: LENS-1242 : Fix JDBCDriver cancel query to
call statement.cancel
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50603/
-----------------------------------------------------------
(Updated July 29, 2016, 11:26 a.m.)
Review request for lens.
Bugs: LENS-1242
https://issues.apache.org/jira/browse/LENS-1242
Repository: lens
Description
-------
- Updated JDBCDriver cancel to call statement.cancel
- At JDBCDriver level we can configure if statement.cancel is supported or not. If set to false, it wont be called.
- Extened cancel test actually run a long running query and cancel it.
Diffs
-----
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 8047302
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java ac0682d
lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 66645b9
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 491aa69
lens-driver-jdbc/src/test/resources/drivers/jdbc/jdbc1/jdbcdriver-site.xml 1202074
src/site/apt/admin/jdbcdriver-config.apt 96c98ad
Diff: https://reviews.apache.org/r/50603/diff/
Testing (updated)
-------
Here are the test times in millis:
testCancelQuery(true) org.apache.lens.driver.jdbc.TestJdbcDriver 185
testCancelQuery(false) org.apache.lens.driver.jdbc.TestJdbcDriver 52
Thanks,
Amareshwari Sriramadasu
Re: Review Request 50603: LENS-1242 : Fix JDBCDriver cancel query to
call statement.cancel
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On July 29, 2016, 11:13 a.m., Puneet Gupta wrote:
> > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java, line 511
> > <https://reviews.apache.org/r/50603/diff/1/?file=1457748#file1457748line511>
> >
> > Do we need this configurable ? We can try either way and log the output if its not supported (SQLFeatureNotSupportedException)
I was not sure if all driver also throw SQLFeatureNotSupportedException as documented. So, added a configuration to play with it on production setup, if required.
During tests noticed that HSQL DB is actually calling close on cancel - which its not terminating the query immediately.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50603/#review144079
-----------------------------------------------------------
On July 29, 2016, 10:48 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50603/
> -----------------------------------------------------------
>
> (Updated July 29, 2016, 10:48 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1242
> https://issues.apache.org/jira/browse/LENS-1242
>
>
> Repository: lens
>
>
> Description
> -------
>
> - Updated JDBCDriver cancel to call statement.cancel
> - At JDBCDriver level we can configure if statement.cancel is supported or not. If set to false, it wont be called.
> - Extened cancel test actually run a long running query and cancel it.
>
>
> Diffs
> -----
>
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 8047302
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java ac0682d
> lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 66645b9
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 491aa69
> lens-driver-jdbc/src/test/resources/drivers/jdbc/jdbc1/jdbcdriver-site.xml 1202074
> src/site/apt/admin/jdbcdriver-config.apt 96c98ad
>
> Diff: https://reviews.apache.org/r/50603/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 50603: LENS-1242 : Fix JDBCDriver cancel query to
call statement.cancel
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50603/#review144079
-----------------------------------------------------------
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java (line 511)
<https://reviews.apache.org/r/50603/#comment210068>
Do we need this configurable ? We can try either way and log the output if its not supported (SQLFeatureNotSupportedException)
- Puneet Gupta
On July 29, 2016, 10:48 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50603/
> -----------------------------------------------------------
>
> (Updated July 29, 2016, 10:48 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1242
> https://issues.apache.org/jira/browse/LENS-1242
>
>
> Repository: lens
>
>
> Description
> -------
>
> - Updated JDBCDriver cancel to call statement.cancel
> - At JDBCDriver level we can configure if statement.cancel is supported or not. If set to false, it wont be called.
> - Extened cancel test actually run a long running query and cancel it.
>
>
> Diffs
> -----
>
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 8047302
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java ac0682d
> lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 66645b9
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 491aa69
> lens-driver-jdbc/src/test/resources/drivers/jdbc/jdbc1/jdbcdriver-site.xml 1202074
> src/site/apt/admin/jdbcdriver-config.apt 96c98ad
>
> Diff: https://reviews.apache.org/r/50603/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>