You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Dylan Adams (JIRA)" <ji...@apache.org> on 2017/05/31 19:05:06 UTC

[jira] [Updated] (CALCITE-1818) SqlImplementor.toSql doesn't handle SqlKind.DYNAMIC correctly

     [ https://issues.apache.org/jira/browse/CALCITE-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dylan Adams updated CALCITE-1818:
---------------------------------
    Attachment: CALCITE-1818.patch

Patch to resolve the issue.

Add case for SqlKind.DYNAMIC to SqlImplementor's toSql method,
converting the RexDynamicParam to SqlDynamicParam.

Added supporting test case.

> SqlImplementor.toSql doesn't handle SqlKind.DYNAMIC correctly
> -------------------------------------------------------------
>
>                 Key: CALCITE-1818
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1818
>             Project: Calcite
>          Issue Type: Bug
>    Affects Versions: 1.11.0, 1.12.0, next
>            Reporter: Dylan Adams
>            Assignee: Julian Hyde
>            Priority: Minor
>         Attachments: CALCITE-1818.patch
>
>
> SqlImplementor.toSql's.toSql doesn't contain logic for converting SqlKind.DYNAMIC to the appropriate SqlNode. Using RelToSqlConverter on a RelNode tree containing RexDynamicParameters, results in the following stack trace:
> {noformat}
> Caused by: java.lang.reflect.InvocationTargetException
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at org.apache.calcite.util.ReflectUtil$2.invoke(ReflectUtil.java:525)
> 	... 33 more
> Caused by: java.lang.RuntimeException: While invoking method 'public org.apache.calcite.rel.rel2sql.SqlImplementor$Result org.apache.calcite.rel.rel2sql.RelToSqlConverter.visit(org.apache.calcite.rel.core.Filter)'
> 	at org.apache.calcite.util.ReflectUtil$2.invoke(ReflectUtil.java:528)
> 	at org.apache.calcite.rel.rel2sql.RelToSqlConverter.dispatch(RelToSqlConverter.java:93)
> 	at org.apache.calcite.rel.rel2sql.RelToSqlConverter.visitChild(RelToSqlConverter.java:97)
> 	at org.apache.calcite.rel.rel2sql.RelToSqlConverter.visit(RelToSqlConverter.java:157)
> 	... 38 more
> Caused by: java.lang.reflect.InvocationTargetException
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at org.apache.calcite.util.ReflectUtil$2.invoke(ReflectUtil.java:525)
> 	... 41 more
> Caused by: java.lang.ClassCastException: org.apache.calcite.rex.RexDynamicParam cannot be cast to org.apache.calcite.rex.RexCall
> 	at org.apache.calcite.rel.rel2sql.SqlImplementor$Context.toSql(SqlImplementor.java:587)
> 	at org.apache.calcite.rel.rel2sql.SqlImplementor$Context.toSql(SqlImplementor.java:742)
> 	at org.apache.calcite.rel.rel2sql.SqlImplementor$Context.toSql(SqlImplementor.java:589)
> 	at org.apache.calcite.rel.rel2sql.SqlImplementor$Context.toSql(SqlImplementor.java:742)
> 	at org.apache.calcite.rel.rel2sql.SqlImplementor$Context.toSql(SqlImplementor.java:589)
> 	at org.apache.calcite.rel.rel2sql.SqlImplementor$Context.toSql(SqlImplementor.java:742)
> 	at org.apache.calcite.rel.rel2sql.SqlImplementor$Context.toSql(SqlImplementor.java:589)
> 	at org.apache.calcite.rel.rel2sql.RelToSqlConverter.visit(RelToSqlConverter.java:150)
> 	... 46 more
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)