[GitHub] [velocity-engine] arkanovicz commented on a change in pull request #16: Velocity 931 update secure classlist

[GitBox <gi...@apache.org>]

arkanovicz commented on a change in pull request #16:
URL: https://github.com/apache/velocity-engine/pull/16#discussion_r583195133



##########
File path: velocity-engine-core/src/test/java/org/apache/velocity/test/SecureIntrospectionTestCase.java
##########
@@ -163,14 +166,35 @@ public void setProperty(String val)
     }
 
 
-	public Collection getCollection()
-	{
-		Collection c = new HashSet();
-		c.add("aaa");
-		c.add("bbb");
-		c.add("ccc");
-		return c;
-	}
+    public Collection getCollection()
+    {
+        Collection c = new HashSet();
+        c.add("aaa");
+        c.add("bbb");
+        c.add("ccc");
+        return c;
+    }
+
+    public ClassLoader getSampleClassLoader1()
+    {
+        return this.getClass().getClassLoader();
+    }
+
+    /**
+     * sample property which is a subclass of ClassLoader
+     * @return
+     */
+    public ClassLoader getSampleClassLoader2()

Review comment:
       Apparently not. I removed them.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org