You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/10/10 13:31:48 UTC
[GitHub] [incubator-kvrocks] PragmaTwice opened a new pull request, #972: Bump CMake minimum required version to 3.16
PragmaTwice opened a new pull request, #972:
URL: https://github.com/apache/incubator-kvrocks/pull/972
We need cmake >= 3.16 since the dependence [glog 0.6 requires at least cmake 3.16](https://github.com/google/glog/blob/v0.6.0/CMakeLists.txt#L1).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on pull request #972: Bump CMake minimum required version to 3.16
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #972:
URL: https://github.com/apache/incubator-kvrocks/pull/972#issuecomment-1273461525
@PragmaTwice Thank you! I think expire tests heavily depend on time relativity and sleep. We may spend some time to make it stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #972: Bump CMake minimum required version to 3.16
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #972:
URL: https://github.com/apache/incubator-kvrocks/pull/972#issuecomment-1273452345
Just for record: https://github.com/apache/incubator-kvrocks/actions/runs/3219906408/jobs/5265964053
```
--- FAIL: TestExpire/PEXPIRE/PSETEX/PEXPIREAT_can_set_sub-second_expires (20.86s)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #972: Bump CMake minimum required version to 3.16
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #972:
URL: https://github.com/apache/incubator-kvrocks/pull/972#issuecomment-1273352165
> I think you should update the version constant on `x.py` correspondingly:
>
> https://github.com/apache/incubator-kvrocks/blob/unstable/x.py#L31
Oh thanks. Forgot it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun merged pull request #972: Bump CMake minimum required version to 3.16
Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #972:
URL: https://github.com/apache/incubator-kvrocks/pull/972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org