You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Navis Ryu <na...@nexr.com> on 2014/09/16 10:11:54 UTC
Review Request 25688: hive jdbc can not used by jmeter,
because of unsupported auto commit feature
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25688/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-6705
https://issues.apache.org/jira/browse/HIVE-6705
Repository: hive-git
Description
-------
In apache jmeter ,the autocommit property is required.
but in the hive jdbc the auto commit is unsupported method.
in
/jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java
{quote}
public void setAutoCommit(boolean autoCommit) throws SQLException {
// TODO Auto-generated method stub
throw new {color:red} SQLException("Method not supported");
{color}
}
{quote}
so ,should we make a mock to support the auto commit property == false ?
{quote}
public void setAutoCommit(boolean autoCommit) throws SQLException {
// TODO Auto-generated method stub
{color:red}if(autoCommit) {color}
throw new SQLException("Method not supported");
else
return;
}
{quote}
Diffs
-----
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java 59ce692
jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java cbcfec7
Diff: https://reviews.apache.org/r/25688/diff/
Testing
-------
Thanks,
Navis Ryu