You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "ammachado (via GitHub)" <gi...@apache.org> on 2023/03/11 20:58:16 UTC
[GitHub] [camel] ammachado opened a new pull request, #9513: Favor CompositeMeterRegistry instances in Camel registry before looki…
ammachado opened a new pull request, #9513:
URL: https://github.com/apache/camel/pull/9513
# Description
Let Micrometer component look for an instance of `CompositeMeterRegistry` on Camel registry before looking for `MeterRegistry` instances.
# Target
- [x] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [x] I formatted the code using `mvn -Pformat,fastinstall install && mvn -Psourcecheck`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #9513: Favor CompositeMeterRegistry instances in Camel registry before looki…
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #9513:
URL: https://github.com/apache/camel/pull/9513#issuecomment-1465122074
What is the use-case?
Can you create a JIRA ticket for such a change and in the commit refer to the CAMEL-NNNNN ticket. And we need to be able to use JIRA to track changes and also plan for which releases to include. Only do PRs without JIRA for small trivial changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9513: Favor CompositeMeterRegistry instances in Camel registry before looki…
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9513:
URL: https://github.com/apache/camel/pull/9513#issuecomment-1465016596
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] ammachado commented on pull request #9513: Favor CompositeMeterRegistry instances in Camel registry before looki…
Posted by "ammachado (via GitHub)" <gi...@apache.org>.
ammachado commented on PR #9513:
URL: https://github.com/apache/camel/pull/9513#issuecomment-1465317476
Created issue [CAMEL-19137](https://issues.apache.org/jira/browse/CAMEL-19137) for this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9513: Favor CompositeMeterRegistry instances in Camel registry before looki…
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9513:
URL: https://github.com/apache/camel/pull/9513#issuecomment-1465033416
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 0 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #9513: Favor CompositeMeterRegistry instances in Camel registry before looki…
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #9513:
URL: https://github.com/apache/camel/pull/9513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org