Re: [PR] HBASE-28783 Concurrent execution of normalizer operations on tables in RegionNormalizerWorker [hbase]

["Apache9 (via GitHub)" <gi...@apache.org>]

Apache9 commented on code in PR #6155:
URL: https://github.com/apache/hbase/pull/6155#discussion_r1852273759


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/RegionNormalizerWorker.java:
##########
@@ -184,18 +195,22 @@ public void run() {
     while (true) {
       if (Thread.interrupted()) {
         LOG.debug("interrupt detected. terminating.");
+        pool.shutdown();
         break;
       }
       final TableName tableName;
       try {
         tableName = workQueue.take();
       } catch (InterruptedException e) {
         LOG.debug("interrupt detected. terminating.");
+        pool.shutdown();
         break;
       }
 
-      final List<NormalizationPlan> plans = calculatePlans(tableName);
-      submitPlans(plans);
+      pool.submit(() -> {
+        final List<NormalizationPlan> plans = calculatePlans(tableName);
+        submitPlans(plans);

Review Comment:
   The name here is a bit confusing, if it just 'submits' the plan, it should not take a lot of time? Does it also execute the plan?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org