You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/07/31 01:04:07 UTC

Review Request 71214: Marked `SET_QUOTA` and `REMOVE_QUOTA` as deprecated.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71214/
-----------------------------------------------------------

Review request for mesos, Andrei Sekretenko and Benjamin Mahler.


Bugs: MESOS-9600
    https://issues.apache.org/jira/browse/MESOS-9600


Repository: mesos


Description
-------

These are deprecated in favor of `UPDATE_QUOTA`.


Diffs
-----

  include/mesos/master/master.proto 07bf4e7194399ef660d7282275f25e1d4563e473 
  include/mesos/v1/master/master.proto 9bcef2f358b50fd63cdfdec5dcad742930de3ecc 


Diff: https://reviews.apache.org/r/71214/diff/1/


Testing
-------

make check


Thanks,

Meng Zhu


Re: Review Request 71214: Marked `SET_QUOTA` and `REMOVE_QUOTA` as deprecated.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71214/#review217022
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71212, 71213, 71214]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 31, 2019, 1:04 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71214/
> -----------------------------------------------------------
> 
> (Updated July 31, 2019, 1:04 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9600
>     https://issues.apache.org/jira/browse/MESOS-9600
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These are deprecated in favor of `UPDATE_QUOTA`.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto 07bf4e7194399ef660d7282275f25e1d4563e473 
>   include/mesos/v1/master/master.proto 9bcef2f358b50fd63cdfdec5dcad742930de3ecc 
> 
> 
> Diff: https://reviews.apache.org/r/71214/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Re: Review Request 71214: Marked `SET_QUOTA` and `REMOVE_QUOTA` as deprecated.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71214/#review217000
-----------------------------------------------------------



Patch looks great!

Reviews applied: [71212, 71213, 71214]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 31, 2019, 1:04 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71214/
> -----------------------------------------------------------
> 
> (Updated July 31, 2019, 1:04 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9600
>     https://issues.apache.org/jira/browse/MESOS-9600
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These are deprecated in favor of `UPDATE_QUOTA`.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto 07bf4e7194399ef660d7282275f25e1d4563e473 
>   include/mesos/v1/master/master.proto 9bcef2f358b50fd63cdfdec5dcad742930de3ecc 
> 
> 
> Diff: https://reviews.apache.org/r/71214/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Re: Review Request 71214: Marked `SET_QUOTA` and `REMOVE_QUOTA` as deprecated.

Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71214/#review217007
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On July 31, 2019, 1:04 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71214/
> -----------------------------------------------------------
> 
> (Updated July 31, 2019, 1:04 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9600
>     https://issues.apache.org/jira/browse/MESOS-9600
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These are deprecated in favor of `UPDATE_QUOTA`.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto 07bf4e7194399ef660d7282275f25e1d4563e473 
>   include/mesos/v1/master/master.proto 9bcef2f358b50fd63cdfdec5dcad742930de3ecc 
> 
> 
> Diff: https://reviews.apache.org/r/71214/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>