You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "chenjinbao1989 (via GitHub)" <gi...@apache.org> on 2026/07/07 15:42:57 UTC
[PR] Fix build against PG16 headers: Value node removal and missing htonl decl [cloudberry-pxf]
chenjinbao1989 opened a new pull request, #123:
URL: https://github.com/apache/cloudberry-pxf/pull/123
pxfuriparser.c and pxf_option.c used the generic Value node type for option-name strings; PG16 split Value into distinct Integer/Float/String/ etc. node types, and makeString()/strVal() now operate on String *, so these failed to compile with "unknown type name 'Value'".
gpdbwritableformatter.c called htonl/ntohl/htons/ntohs without including arpa/inet.h. This used to be a silent implicit-declaration warning but is a hard error under GCC 13's -Werror=implicit-function-declaration.
<!--Thank you for contributing! -->
<!--In case of an existing issue or discussions, please reference it-->
closes: #ISSUE_Number
<!--Remove this section if no corresponding issue.-->
---
## Change logs
> Describe your change clearly, including what problem is being solved or what document is being added or updated.
## Contributor's checklist
Here are some reminders before you submit your pull request:
* Make sure that your Pull Request has a clear title and commit message. You can take the [Git commit template](https://github.com/apache/cloudberry/blob/main/.gitmessage) as a reference.
* Learn the [code contribution](https://cloudberry.apache.org/contribute/code) and [doc contribution](https://cloudberry.apache.org/contribute/doc) guides for better collaboration.
* Make sure that CICD workflow is successful.
* List your communications in the [GitHub Issues](https://github.com/apache/cloudberry-pxf/issues) or [Discussions](https://github.com/apache/cloudberry/discussions) (if has or needed).
* Feel free to ask for the [cloudberry committers](https://github.com/orgs/apache/teams/cloudberry-committers) or other people to help review and approve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix build against PG16 headers: Value node removal and missing htonl decl [cloudberry-pxf]
Posted by "ostinru (via GitHub)" <gi...@apache.org>.
ostinru commented on PR #123:
URL: https://github.com/apache/cloudberry-pxf/pull/123#issuecomment-4912188896
I think that we can support cloudberry 2.x and 3.x in a single cloudberry-pxf codebase with some `#ifdef`s on C-lang side. This will allow us to compile and use cloudberry-pxf-3.x with cloudberry-2.x. This way we will avoid supporting multiple branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix build against PG16 headers: Value node removal and missing htonl decl [cloudberry-pxf]
Posted by "MisterRaindrop (via GitHub)" <gi...@apache.org>.
MisterRaindrop commented on PR #123:
URL: https://github.com/apache/cloudberry-pxf/pull/123#issuecomment-4910509356
I see external-table/test/pxfprotocol_test.c file still use `Value *v = makeString(uri_no_profile);` need modify
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix build against PG16 headers: Value node removal and missing htonl decl [cloudberry-pxf]
Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe commented on code in PR #123:
URL: https://github.com/apache/cloudberry-pxf/pull/123#discussion_r3575575998
##########
.github/workflows/pxf-ci.yml:
##########
@@ -40,7 +40,7 @@ env:
JAVA_HOME: "/usr/lib/jvm/java-11-openjdk"
GO_VERSION: "1.25"
GPHOME: "/usr/local/cloudberry-db"
- CLOUDBERRY_VERSION: "REL_2_STABLE"
+ CLOUDBERRY_VERSION: "main"
Review Comment:
I think we can create a branch matrix to test both these branches until 2.X is EOL in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix build against PG16 headers: Value node removal and missing htonl decl [cloudberry-pxf]
Posted by "MisterRaindrop (via GitHub)" <gi...@apache.org>.
MisterRaindrop merged PR #123:
URL: https://github.com/apache/cloudberry-pxf/pull/123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix build against PG16 headers: Value node removal and missing htonl decl [cloudberry-pxf]
Posted by "ostinru (via GitHub)" <gi...@apache.org>.
ostinru commented on PR #123:
URL: https://github.com/apache/cloudberry-pxf/pull/123#issuecomment-4907122857
Compilation with cloudberry 2.x got broken. e.g. in [Test PXF - fdw](https://github.com/apache/cloudberry-pxf/actions/runs/28879173619/job/85664437488?pr=123#logs)
```
pxf_option.c:473:25: error: unknown type name ‘String’
473 | String *val = makeString(def->defname);
| ^~~~~~
pxf_option.c:473:43: warning: initialization of ‘int *’ from incompatible pointer type ‘Value *’ [-Wincompatible-pointer-types]
473 | String *val = makeString(def->defname);
| ^~~~~~~~~~
make: *** [<builtin>: pxf_option.o] Error 1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix build against PG16 headers: Value node removal and missing htonl decl [cloudberry-pxf]
Posted by "MisterRaindrop (via GitHub)" <gi...@apache.org>.
MisterRaindrop commented on code in PR #123:
URL: https://github.com/apache/cloudberry-pxf/pull/123#discussion_r3922538799
##########
.github/workflows/pxf-ci.yml:
##########
@@ -40,7 +40,7 @@ env:
JAVA_HOME: "/usr/lib/jvm/java-11-openjdk"
GO_VERSION: "1.25"
GPHOME: "/usr/local/cloudberry-db"
- CLOUDBERRY_VERSION: "REL_2_STABLE"
+ CLOUDBERRY_VERSION: "main"
Review Comment:
Implemented. Rocky 9 now builds RPMs for both `REL_2_STABLE` and `main`. Cache keys and artifacts include the Cloudberry ref/commit, and CI verifies the installed PostgreSQL major before building PXF. Both native-extension jobs passed with PG14 and PG16.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix build against PG16 headers: Value node removal and missing htonl decl [cloudberry-pxf]
Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe commented on PR #123:
URL: https://github.com/apache/cloudberry-pxf/pull/123#issuecomment-5566264020
> REL_2_STABLE and current `main` is `3.0.0-SNAPSH`
Yes. Go ahead!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix build against PG16 headers: Value node removal and missing htonl decl [cloudberry-pxf]
Posted by "tuhaihe (via GitHub)" <gi...@apache.org>.
tuhaihe commented on PR #123:
URL: https://github.com/apache/cloudberry-pxf/pull/123#issuecomment-4910707396
Besides the `REL_2_STABLE` branch, should we add Cloudberry main branch support to the CI workflow?
https://github.com/apache/cloudberry-pxf/blob/75cf1f61795bacf58f2f1e36eb97e57f8f935324/.github/workflows/pxf-ci.yml#L38-L44
Then we can verify if the changes work, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix build against PG16 headers: Value node removal and missing htonl decl [cloudberry-pxf]
Posted by "ostinru (via GitHub)" <gi...@apache.org>.
ostinru commented on PR #123:
URL: https://github.com/apache/cloudberry-pxf/pull/123#issuecomment-5566194206
@tuhaihe, Am I correct, that PXF-2.2 moved to REL_2_STABLE and current `main` is `3.0.0-SNAPSHOT`? So, we are ready to merge PXF-3 commits to main?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix build against PG16 headers: Value node removal and missing htonl decl [cloudberry-pxf]
Posted by "MisterRaindrop (via GitHub)" <gi...@apache.org>.
MisterRaindrop commented on PR #123:
URL: https://github.com/apache/cloudberry-pxf/pull/123#issuecomment-5564612786
@chenjinbao1989 @ostinru please review it, code is ready
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org
Re: [PR] Fix build against PG16 headers: Value node removal and missing htonl decl [cloudberry-pxf]
Posted by "MisterRaindrop (via GitHub)" <gi...@apache.org>.
MisterRaindrop commented on PR #123:
URL: https://github.com/apache/cloudberry-pxf/pull/123#issuecomment-5522807626
Updated the PR:
- Replaced version-specific `Value *` / `String *` declarations with `Node *` casts, including `pxfprotocol_test.c`.
- Kept one source tree compatible with Cloudberry 2.x and main.
- Added a `REL_2_STABLE` / `main` RPM matrix with ref- and commit-scoped artifacts.
- Added installed-version checks before building PXF.
Verified in [CI run 33731109264](https://github.com/apache/cloudberry-pxf/actions/runs/33731109264):
- `REL_2_STABLE`: PostgreSQL 14.9 / Cloudberry 2.2.0-incubating
- `main`: PostgreSQL 16.9 / Cloudberry 3.0.0-devel
Both native-extension build jobs passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org