You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "z3d1k (via GitHub)" <gi...@apache.org> on 2023/01/23 15:22:57 UTC
[GitHub] [flink-connector-aws] z3d1k opened a new pull request, #48: [FLINK-30762] Add nightly build workflow
z3d1k opened a new pull request, #48:
URL: https://github.com/apache/flink-connector-aws/pull/48
- Extracted existing build logic into common reusable workflow
- Added nightly build against SNAPSHOT versions of Flink
- Update actions to address Node 12 actions deprecation notice:
- `actions/checkout` to `v3`
- `actions/setup-java` to `v3`
- `stCarolas/setup-maven` to `v4.5`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] boring-cyborg[bot] commented on pull request #48: [FLINK-30762] Add nightly build workflow
Posted by boring-cyborg.
boring-cyborg[bot] commented on PR #48:
URL: https://github.com/apache/flink-connector-aws/pull/48#issuecomment-1400531085
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] z3d1k commented on a diff in pull request #48: [FLINK-30762][ci] Add nightly build workflow
Posted by "z3d1k (via GitHub)" <gi...@apache.org>.
z3d1k commented on code in PR #48:
URL: https://github.com/apache/flink-connector-aws/pull/48#discussion_r1085538878
##########
.github/workflows/common.yml:
##########
@@ -16,66 +16,87 @@
# limitations under the License.
################################################################################
-name: Build flink-connector-aws
-on: [push, pull_request]
-concurrency:
- group: ${{ github.workflow }}-${{ github.ref }}
- cancel-in-progress: true
+on:
+ workflow_call:
+ inputs:
+ flink_url:
+ description: "Url to Flink binary."
+ required: true
+ type: string
+ flink_version:
+ description: "Flink version to test against."
+ required: true
+ type: string
+ cache_flink_binary:
+ description: "Whether to cache the Flink binary. Should be false for SNAPSHOT URLs, true otherwise."
+ required: true
+ type: boolean
+ timeout_global:
+ description: "The timeout in minutes for the entire workflow."
+ required: false
+ type: number
+ default: 60
+ timeout_test:
+ description: "The timeout in minutes for the test compile&step."
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] boring-cyborg[bot] commented on pull request #48: [FLINK-30762][ci] Add nightly build workflow
Posted by boring-cyborg.
boring-cyborg[bot] commented on PR #48:
URL: https://github.com/apache/flink-connector-aws/pull/48#issuecomment-1403569682
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] dannycranmer merged pull request #48: [FLINK-30762][ci] Add nightly build workflow
Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer merged PR #48:
URL: https://github.com/apache/flink-connector-aws/pull/48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] hlteoh37 commented on a diff in pull request #48: [FLINK-30762] Add nightly build workflow
Posted by "hlteoh37 (via GitHub)" <gi...@apache.org>.
hlteoh37 commented on code in PR #48:
URL: https://github.com/apache/flink-connector-aws/pull/48#discussion_r1084264894
##########
.github/workflows/nightly.yml:
##########
@@ -0,0 +1,33 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+name: Nightly
Review Comment:
nit: add `flink-connector-aws`?
##########
.github/workflows/common.yml:
##########
@@ -16,66 +16,87 @@
# limitations under the License.
################################################################################
-name: Build flink-connector-aws
-on: [push, pull_request]
-concurrency:
- group: ${{ github.workflow }}-${{ github.ref }}
- cancel-in-progress: true
+on:
+ workflow_call:
+ inputs:
+ flink_url:
+ description: "Url to Flink binary."
+ required: true
+ type: string
+ flink_version:
+ description: "Flink version to test against."
+ required: true
+ type: string
+ cache_flink_binary:
+ description: "Whether to cache the Flink binary. Should be false for SNAPSHOT URLs, true otherwise."
+ required: true
+ type: boolean
+ timeout_global:
+ description: "The timeout in minutes for the entire workflow."
+ required: false
+ type: number
+ default: 60
+ timeout_test:
+ description: "The timeout in minutes for the test compile&step."
Review Comment:
nit: the `&` seems misplaced
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-aws] z3d1k commented on a diff in pull request #48: [FLINK-30762][ci] Add nightly build workflow
Posted by "z3d1k (via GitHub)" <gi...@apache.org>.
z3d1k commented on code in PR #48:
URL: https://github.com/apache/flink-connector-aws/pull/48#discussion_r1085539586
##########
.github/workflows/nightly.yml:
##########
@@ -0,0 +1,33 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+name: Nightly
Review Comment:
renamed workflows to include `flink-connector-aws`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org