Re: [I] [SUREFIRE-2167] Simplify deserialization of elapsed time in TestSuiteXmlParser [maven-surefire]

["thomasmey (via GitHub)" <gi...@apache.org>]

thomasmey commented on issue #2715:
URL: https://github.com/apache/maven-surefire/issues/2715#issuecomment-3636000251

   Hi, @michael-o sadly this change did break the reporting of reports generated with LegacyXmlReportGeneratingListener in junit. The junit code seems create the time attributlike the maven-surefire reporting plugin did parse before, i.e. via NumberFormat.parse().
   See also https://github.com/junit-team/junit-framework/blob/main/junit-platform-reporting/src/main/java/org/junit/platform/reporting/legacy/xml/XmlReportWriter.java#L167
   
   For testsuites the Float.parse seems to work when the time number is smaller then 1000, the time attribute will look like this then: time="394.879", but when the testsuite runs longer the created time attribute will look like time="1,323.333", which make Float parse fail.
   
   can you please revert this change and make things compatible again?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org