You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/25 23:53:00 UTC

[GitHub] [spark] sunchao commented on a change in pull request #34383: [SPARK-37102][BUILD] Removed redundant exclusions in `hadoop-cloud` module

sunchao commented on a change in pull request #34383:
URL: https://github.com/apache/spark/pull/34383#discussion_r736043972



##########
File path: hadoop-cloud/pom.xml
##########
@@ -184,18 +171,6 @@
           <groupId>org.apache.hadoop</groupId>
           <artifactId>hadoop-common</artifactId>
         </exclusion>
-        <exclusion>
-          <groupId>org.codehaus.jackson</groupId>
-          <artifactId>jackson-mapper-asl</artifactId>
-        </exclusion>
-        <exclusion>
-          <groupId>com.fasterxml.jackson.core</groupId>
-          <artifactId>jackson-core</artifactId>
-        </exclusion>
-        <exclusion>
-          <groupId>com.google.guava</groupId>

Review comment:
       why include Guava?

##########
File path: hadoop-cloud/pom.xml
##########
@@ -136,7 +124,6 @@
         </exclusion>
       </exclusions>
     </dependency>
-

Review comment:
       nit: unnecessary change.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org