You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2019/12/18 20:55:31 UTC
[commons-collections] 02/02: Remove unnecessary array creation for
varargs.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-collections.git
commit 8308cff798f36d82bb1f8d5fb8718d47a466708a
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Wed Dec 18 15:55:25 2019 -0500
Remove unnecessary array creation for varargs.
---
.../org/apache/commons/collections4/functors/PrototypeFactory.java | 2 +-
src/test/java/org/apache/commons/collections4/BulkTest.java | 2 +-
src/test/java/org/apache/commons/collections4/ClosureUtilsTest.java | 6 +++---
.../java/org/apache/commons/collections4/CollectionUtilsTest.java | 2 +-
.../java/org/apache/commons/collections4/TransformerUtilsTest.java | 6 +++---
5 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/main/java/org/apache/commons/collections4/functors/PrototypeFactory.java b/src/main/java/org/apache/commons/collections4/functors/PrototypeFactory.java
index 20045af..4c19f2a 100644
--- a/src/main/java/org/apache/commons/collections4/functors/PrototypeFactory.java
+++ b/src/main/java/org/apache/commons/collections4/functors/PrototypeFactory.java
@@ -73,7 +73,7 @@ public class PrototypeFactory {
} catch (final NoSuchMethodException ex) {
try {
- prototype.getClass().getConstructor(new Class<?>[] { prototype.getClass() });
+ prototype.getClass().getConstructor(prototype.getClass());
return new InstantiateFactory<>(
(Class<T>) prototype.getClass(),
new Class<?>[] { prototype.getClass() },
diff --git a/src/test/java/org/apache/commons/collections4/BulkTest.java b/src/test/java/org/apache/commons/collections4/BulkTest.java
index bbe4f62..80e055a 100644
--- a/src/test/java/org/apache/commons/collections4/BulkTest.java
+++ b/src/test/java/org/apache/commons/collections4/BulkTest.java
@@ -416,7 +416,7 @@ class BulkTestSuiteMaker {
private static <T> Constructor<T> getTestCaseConstructor(final Class<T> c) {
try {
- return c.getConstructor(new Class[] { String.class });
+ return c.getConstructor(String.class);
} catch (final NoSuchMethodException e) {
throw new IllegalArgumentException(c + " must provide a (String) constructor");
}
diff --git a/src/test/java/org/apache/commons/collections4/ClosureUtilsTest.java b/src/test/java/org/apache/commons/collections4/ClosureUtilsTest.java
index f4fa7bd..0bfaa43 100644
--- a/src/test/java/org/apache/commons/collections4/ClosureUtilsTest.java
+++ b/src/test/java/org/apache/commons/collections4/ClosureUtilsTest.java
@@ -182,7 +182,7 @@ public class ClosureUtilsTest {
a = new MockClosure<>();
b = new MockClosure<>();
- ClosureUtils.<Object>chainedClosure(new Closure[] {a, b, a}).execute(null);
+ ClosureUtils.<Object>chainedClosure(a, b, a).execute(null);
assertEquals(2, a.count);
assertEquals(1, b.count);
@@ -196,7 +196,7 @@ public class ClosureUtilsTest {
assertEquals(1, a.count);
assertEquals(2, b.count);
- assertSame(NOPClosure.INSTANCE, ClosureUtils.<Object>chainedClosure(new Closure[0]));
+ assertSame(NOPClosure.INSTANCE, ClosureUtils.<Object>chainedClosure());
assertSame(NOPClosure.INSTANCE, ClosureUtils.<Object>chainedClosure(Collections.<Closure<Object>>emptyList()));
try {
@@ -212,7 +212,7 @@ public class ClosureUtilsTest {
fail();
} catch (final NullPointerException ex) {}
try {
- ClosureUtils.<Object>chainedClosure(new Closure[] {null, null});
+ ClosureUtils.<Object>chainedClosure(null, null);
fail();
} catch (final NullPointerException ex) {}
try {
diff --git a/src/test/java/org/apache/commons/collections4/CollectionUtilsTest.java b/src/test/java/org/apache/commons/collections4/CollectionUtilsTest.java
index 6f4a5b1..fca9f30 100644
--- a/src/test/java/org/apache/commons/collections4/CollectionUtilsTest.java
+++ b/src/test/java/org/apache/commons/collections4/CollectionUtilsTest.java
@@ -1737,7 +1737,7 @@ public class CollectionUtilsTest extends MockTestCase {
@Test
public void addAllForElements() {
- CollectionUtils.addAll(collectionA, new Integer[]{5});
+ CollectionUtils.addAll(collectionA, 5);
assertTrue(collectionA.contains(5));
}
diff --git a/src/test/java/org/apache/commons/collections4/TransformerUtilsTest.java b/src/test/java/org/apache/commons/collections4/TransformerUtilsTest.java
index b47d10f..50361a2 100644
--- a/src/test/java/org/apache/commons/collections4/TransformerUtilsTest.java
+++ b/src/test/java/org/apache/commons/collections4/TransformerUtilsTest.java
@@ -201,13 +201,13 @@ public class TransformerUtilsTest {
assertEquals("A", TransformerUtils.chainedTransformer(b, a).transform(null));
assertEquals("B", TransformerUtils.chainedTransformer(a, b).transform(null));
- assertEquals("A", TransformerUtils.chainedTransformer(new Transformer[] { b, a }).transform(null));
+ assertEquals("A", TransformerUtils.chainedTransformer(b, a).transform(null));
Collection<Transformer<Object, Object>> coll = new ArrayList<>();
coll.add(b);
coll.add(a);
assertEquals("A", TransformerUtils.chainedTransformer(coll).transform(null));
- assertSame(NOPTransformer.INSTANCE, TransformerUtils.chainedTransformer(new Transformer[0]));
+ assertSame(NOPTransformer.INSTANCE, TransformerUtils.chainedTransformer());
assertSame(NOPTransformer.INSTANCE, TransformerUtils.chainedTransformer(Collections.<Transformer<Object, Object>>emptyList()));
try {
@@ -223,7 +223,7 @@ public class TransformerUtilsTest {
fail();
} catch (final NullPointerException ex) {}
try {
- TransformerUtils.chainedTransformer(new Transformer[] {null, null});
+ TransformerUtils.chainedTransformer(null, null);
fail();
} catch (final NullPointerException ex) {}
try {