You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/05/19 10:30:14 UTC

[GitHub] [incubator-apisix] xxm404 opened a new pull request #1598: Fix garbled Chinese response in browser. close #1559

xxm404 opened a new pull request #1598:
URL: https://github.com/apache/incubator-apisix/pull/1598


   
   https://github.com/apache/incubator-apisix/blob/master/Contributing.md#how-to-add-a-new-feature-or-change-an-existing-one
   
   ### Summary
   
   Modify APISIX Nginx template to solve #1559
   
   ### Full changelog
   
   * Add `charset utf-8;` in APISIX Nginx config template
   
   ### Issues resolved
   
   Fix #1559
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on pull request #1598: Fix garbled Chinese response in browser. close #1559

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1598:
URL: https://github.com/apache/incubator-apisix/pull/1598#issuecomment-633617552


   @xxm404 many thx, merged already


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] moonming commented on pull request #1598: Fix garbled Chinese response in browser. close #1559

Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #1598:
URL: https://github.com/apache/incubator-apisix/pull/1598#issuecomment-630831150


   @xxm404 it will be better if you can add test cases for this PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] xxm404 commented on pull request #1598: Fix garbled Chinese response in browser. close #1559

Posted by GitBox <gi...@apache.org>.
xxm404 commented on pull request #1598:
URL: https://github.com/apache/incubator-apisix/pull/1598#issuecomment-631206829


   > @xxm404 it will be better if you can add test cases for this PR
   
   This problem only occurred in the browser, how to test by test Nginx


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis merged pull request #1598: Fix garbled Chinese response in browser. close #1559

Posted by GitBox <gi...@apache.org>.
membphis merged pull request #1598:
URL: https://github.com/apache/incubator-apisix/pull/1598


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] griffenliu commented on pull request #1598: Fix garbled Chinese response in browser. close #1559

Posted by GitBox <gi...@apache.org>.
griffenliu commented on pull request #1598:
URL: https://github.com/apache/incubator-apisix/pull/1598#issuecomment-631227844


   Hi, @xxm404 :
   Consider the following code for increased  flexibility?
   ```
   include mime.types;
   {% if http.charset then %}
   charset {* http.charset *};
   {% end %}
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] xxm404 commented on pull request #1598: Fix garbled Chinese response in browser. close #1559

Posted by GitBox <gi...@apache.org>.
xxm404 commented on pull request #1598:
URL: https://github.com/apache/incubator-apisix/pull/1598#issuecomment-631299549


   > Hi, @xxm404 :
   > Consider the following code for increased flexibility?
   > 
   > ```
   > include mime.types;
   > {% if http.charset then %}
   > charset {* http.charset *};
   > {% end %}
   > ```
   
   Good idea, But in my opinion, Nginx charset won't be modified frequently, We shouldn't complicate config.yaml


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org