You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/07 09:01:53 UTC

[GitHub] [airflow] eladkal commented on a diff in pull request #24895: Adding ElasticserachPythonHook - ES Hook With The Python Client

eladkal commented on code in PR #24895:
URL: https://github.com/apache/airflow/pull/24895#discussion_r915637328


##########
airflow/providers/elasticsearch/hooks/elasticsearch_python.py:
##########
@@ -0,0 +1,56 @@
+#

Review Comment:
   So we have two ways to interact with elastic one is Python based with the SDK and one is SQL based by using sql query syntax.
   
   i think we should rename this file as `python.py` or something similar?
   and the current `ElasticsearchHook` in hooks/elasticsearch.py  
   https://github.com/apache/airflow/blob/7a9c03caaf5b954057f7a566b7406982e67f9749/airflow/providers/elasticsearch/hooks/elasticsearch.py#L27 should be hooks/sql.py with `ElasticsearchSqlHook`
   
   
   Alternatively, we can have both classes `ElasticsearchSqlHook` + `ElasticsearchPythonHook` in the same `hooks/elasticsearch.py` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org