[GitHub] [helix] xyuanlu commented on a change in pull request #1812: Implement Participant Freeze Process

[GitBox <gi...@apache.org>]

xyuanlu commented on a change in pull request #1812:
URL: https://github.com/apache/helix/pull/1812#discussion_r668983484



##########
File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java
##########
@@ -1317,6 +1318,13 @@ public void handleNewSession(String sessionId) throws Exception {
     LOG.info("Handle new session, instance: {}, type: {}, session id: {}.", _instanceName,
         _instanceType,  sessionId);
 
+    // Will only create live instance
+    if (LiveInstance.LiveInstanceStatus.PAUSED

Review comment:
       The change looks good to me. 
   Nit: I think usually we follow this pattern when comparing: 
   `variable.equal(some_static_value)`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org