[jira] [Commented] (SQOOP-2445) Sqoop2: Generic JDBC: Prevent use of tableColumns and sql at the same time

["Sqoop QA bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SQOOP-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720384#comment-14720384 ] 

Sqoop QA bot commented on SQOOP-2445:
-------------------------------------

Testing file [SQOOP-2445.patch|https://issues.apache.org/jira/secure/attachment/12753031/SQOOP-2445.patch] against branch sqoop2 took 0:52:59.035630.

{color:green}Overall:{color} +1 all checks pass

{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} Patch add/modify test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 1404 tests)
{color:green}SUCCESS:{color} Test coverage did not decreased ([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1651/artifact/patch-process/cobertura_report.txt])
{color:green}SUCCESS:{color} No new findbugs warnings ([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1651/artifact/patch-process/findbugs_report.txt])
{color:green}SUCCESS:{color} All integration tests passed (executed 73 tests)

Console output is available [here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1651/console].

This message is automatically generated.

> Sqoop2: Generic JDBC: Prevent use of tableColumns and sql at the same time
> --------------------------------------------------------------------------
>
>                 Key: SQOOP-2445
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2445
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 1.99.7
>
>         Attachments: SQOOP-2445.patch
>
>
> We're supporting data retrieval with custom query. I see bunch of code around that is trying to solve situation when user enters both of custom query and specifies what columns he wants to transfer from that custom query. This seems to me as unnecessary complication as user can limit the column in the first place by specifying appropriate query. Hence I would like to prohibit this behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)