You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/07/14 04:18:23 UTC
[GitHub] [helix] narendly opened a new pull request #1147: Remove legacy duplicate metric classes in helix-core
narendly opened a new pull request #1147:
URL: https://github.com/apache/helix/pull/1147
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR description:
Fixes #1146
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
As part of ZooKeeper API separation initiative, most metric-related classes were moved to metrics-common module. However, there were some that were left in helix-core for backward-compatibility purposes, but these were causing class conflicts at runtime. This change removes such classes.
### Tests
- [ ] The following tests are written for this issue:
No tests written.
- [ ] The following is the result of the "mvn test" command on the appropriate module:
Pending...
### Commits
- [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- [x] My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on a change in pull request #1147: Remove legacy duplicate metric classes in helix-core
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on a change in pull request #1147:
URL: https://github.com/apache/helix/pull/1147#discussion_r454154393
##########
File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterEventMonitor.java
##########
@@ -31,6 +31,7 @@
import org.apache.helix.monitoring.mbeans.dynamicMBeans.HistogramDynamicMetric;
import org.apache.helix.monitoring.mbeans.dynamicMBeans.SimpleDynamicMetric;
+
Review comment:
I personally don't like 2 lines. It makes the code looks longer and not concise. I see @pkuwm did that change before. @pkuwm, is there a particular reason we want 2 lines instead of one?
And @narendly, please put the reformat changes to a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly merged pull request #1147: Remove legacy duplicate metric classes in helix-core
Posted by GitBox <gi...@apache.org>.
narendly merged pull request #1147:
URL: https://github.com/apache/helix/pull/1147
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on a change in pull request #1147: Remove legacy duplicate metric classes in helix-core
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on a change in pull request #1147:
URL: https://github.com/apache/helix/pull/1147#discussion_r454119444
##########
File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterEventMonitor.java
##########
@@ -31,6 +31,7 @@
import org.apache.helix.monitoring.mbeans.dynamicMBeans.HistogramDynamicMetric;
import org.apache.helix.monitoring.mbeans.dynamicMBeans.SimpleDynamicMetric;
+
Review comment:
I think the template is one line between the imports and the code, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on pull request #1147: Remove legacy duplicate metric classes in helix-core
Posted by GitBox <gi...@apache.org>.
narendly commented on pull request #1147:
URL: https://github.com/apache/helix/pull/1147#issuecomment-657958916
@pkuwm It seems that you submitted a change in DynamicMBeanProvider.java recently. Could you give this a quick look and make sure your change wasn't overriden?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on a change in pull request #1147: Remove legacy duplicate metric classes in helix-core
Posted by GitBox <gi...@apache.org>.
narendly commented on a change in pull request #1147:
URL: https://github.com/apache/helix/pull/1147#discussion_r454140109
##########
File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterEventMonitor.java
##########
@@ -31,6 +31,7 @@
import org.apache.helix.monitoring.mbeans.dynamicMBeans.HistogramDynamicMetric;
import org.apache.helix.monitoring.mbeans.dynamicMBeans.SimpleDynamicMetric;
+
Review comment:
It's giving it two lines on the latest master format file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on a change in pull request #1147: Remove legacy duplicate metric classes in helix-core
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on a change in pull request #1147:
URL: https://github.com/apache/helix/pull/1147#discussion_r454592276
##########
File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterEventMonitor.java
##########
@@ -31,6 +31,7 @@
import org.apache.helix.monitoring.mbeans.dynamicMBeans.HistogramDynamicMetric;
import org.apache.helix.monitoring.mbeans.dynamicMBeans.SimpleDynamicMetric;
+
Review comment:
@pkuwm yes, I prefer 1 line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm commented on a change in pull request #1147: Remove legacy duplicate metric classes in helix-core
Posted by GitBox <gi...@apache.org>.
pkuwm commented on a change in pull request #1147:
URL: https://github.com/apache/helix/pull/1147#discussion_r454166481
##########
File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterEventMonitor.java
##########
@@ -31,6 +31,7 @@
import org.apache.helix.monitoring.mbeans.dynamicMBeans.HistogramDynamicMetric;
import org.apache.helix.monitoring.mbeans.dynamicMBeans.SimpleDynamicMetric;
+
Review comment:
@jiajunwang Double checked. The 2 lines setting is consistent with LinkedIn's java coding convention.
I actually prefer 1 line, as well. If we agree on making it 1 line, let me change it. Could we confirm that 1 line is preferred? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly edited a comment on pull request #1147: Remove legacy duplicate metric classes in helix-core
Posted by GitBox <gi...@apache.org>.
narendly edited a comment on pull request #1147:
URL: https://github.com/apache/helix/pull/1147#issuecomment-657958916
@pkuwm It seems that you submitted a change to DynamicMBeanProvider.java recently. Could you give this a quick look and make sure your change wasn't overriden?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org