You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "xinrong-meng (via GitHub)" <gi...@apache.org> on 2023/07/14 18:24:55 UTC

[GitHub] [spark] xinrong-meng commented on a diff in pull request #41989: [SPARK-43965][PYTHON][CONNECT] Support Python UDTF in Spark Connect

xinrong-meng commented on code in PR #41989:
URL: https://github.com/apache/spark/pull/41989#discussion_r1264023458


##########
connector/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -941,6 +942,36 @@ message ApplyInPandasWithState {
   string timeout_conf = 7;
 }
 
+message CommonInlineUserDefinedTableFunction {
+  // (Required) Name of the user-defined table function.
+  string function_name = 1;
+
+  // (Optional) Whether the user-defined table function is deterministic.
+  bool deterministic = 2;
+
+  // (Optional) Function input arguments. Empty arguments are allowed.
+  repeated Expression arguments = 3;
+
+  // (Required) Type of the user-defined table function.
+  oneof function {
+    PythonUDTF python_udtf = 4;

Review Comment:
   Out of curiosity will there be UDTFs in other languages?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org