You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by David Graham <dg...@hotmail.com> on 2003/04/22 20:22:10 UTC

RE: [Pool] What's left for a release?

Struts does not use commons-pool directly, we inherit the dependency from 
our use of DBCP.  If you're comfortable with the change and it won't break 
DBCP (which we also need a release of), then I'm fine with it.

We still haven't heard what variables subclasses need access to that don't 
already have accessors.

David



>From: Rodney Waldhoff <rw...@apache.org>
>Reply-To: "Jakarta Commons Developers List" 
><co...@jakarta.apache.org>
>To: Jakarta Commons Developers List <co...@jakarta.apache.org>
>Subject: RE: [Pool] What's left for a release?
>Date: Tue, 22 Apr 2003 11:12:20 -0700 (PDT)
>
>Ok, but you may not like all my answers.
>
>Regarding <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19192>, I
>think I'm reasonably comfortable with making this change before the 2.0
>release--this simply unsyncs the factory's makeObject method, which
>shouldn't need to be locked by the pool anyway.  Also, addObject stands in
>isolation--none of the other pool methods invoke it, so this will only
>impact those who "prepopulate" or otherwise add things to the pool
>manually.  If struts doesn't do that, then maybe David will be more
>comfortable with the change.  If it'll keep everyone happy, maybe we
>should do a 2.0 release without that change and immediately follow it up
>this change (either as a 2.0.1 or SNAPSHOT release).
>
>Regarding "allowing advanced use of [GenericObjectPool] by subclassing", I
>happen to have posted an article just yesterday (see
><http://radio.weblogs.com/0122027/stories/2003/04/21/areConcreteParentClassesACodeSmell.html>)
>that argues against concrete parent types. Honestly, I think the pool API
>would be better served by some refactoring to better allow customization
>via composition rather than inheritance.  The current design offers one
>type of partitioning--separating the pool management from the object
>lifecycle--but fails to support all the axes and degrees of variation that
>are desired.  I have some notes that discuss this in greater detail that I
>had originally intended to post as "proposal", but it began to seem like
>it'd be easier just to check it in an let someone veto if they way.
>Following the 2.0 release I'll try to do one or the other.
>
>- Rod <http://radio.weblogs.com/0122027/>
>
>On Tue, 22 Apr 2003, Gary Gregory wrote:
>
> > Rodney,
> >
> > I see your name as the author for GenericObjectPool. Do you have any
> > thoughts to share with us on this topic?
> >
> > Thanks,
> > Gary
> >
> > -----Original Message-----
> > From: Gary Gregory [mailto:ggregory@seagullsw.com]
> > Sent: Tuesday, April 22, 2003 10:28 AM
> > To: 'Jakarta Commons Developers List'
> > Subject: RE: [Pool] What's left for a release?
> >
> > David,
> >
> > Well, here we could split this into two issues. I do not like (1) and I 
>am
> > in favor for (2).
> >
> > (1) Which exact one field in GenericObjectPool would we need to change 
>to
> > protected access to address our current problem? We could make this one
> > field protected in 2.0. We could then create our own subclass and define 
>the
> > behavior we need. You would end up with GenericObjectPool that has one 
>ivar
> > protected and all others private, which is oddly inconsistent and needs 
>to
> > be explained in the docs. The next time a problem shows up which /could/
> > have been solved with a subclass, we are back to where we started: You 
>could
> > subclass if only field f was protected instead of private. I claim this 
>is
> > not the way to go.
> >
> > (2) GenericObjectPool is a nice re-usable class, at runtime. As the 
>Javadoc
> > states it is "configurable". My claim is that full reusability would be
> > better served by allowing advanced use of the class via subclassing.
> >
> > Here, http://jakarta.apache.org/commons/pool/, states: "A generic object
> > pool interface that clients and implementors can use to provide easily
> > interchangable pooling implementations." (Webmaster, interchangable ->
> > interchangeable.)
> >
> > Well, we would like to be implementing our own pool to customize 
>behavior in
> > GenericObjectPool, but we cannot. Hence the request to simply make 
>fields
> > and methods that are now private protected. This would allow subclassing 
>to
> > work, always. Why not solve this problem once?
> >
> > Thanks for taking the time to consider this issue, BTW.
> >
> > Gary
> >
> > PS: I cannot tell how many times this happens with third party code... 
>GG.
> >
> > -----Original Message-----
> > From: David Graham [mailto:dgraham1980@hotmail.com]
> > Sent: Tuesday, April 22, 2003 10:00 AM
> > To: commons-dev@jakarta.apache.org
> > Subject: RE: [Pool] What's left for a release?
> >
> > Specifically, which fields do you want protected access for that you 
>can't
> > get to via accessors?
> >
> > David
> >
> >
> >
> > >From: Gary Gregory <gg...@seagullsw.com>
> > >Reply-To: "Jakarta Commons Developers List"
> > ><co...@jakarta.apache.org>
> > >To: 'Jakarta Commons Developers List' <co...@jakarta.apache.org>
> > >Subject: RE: [Pool] What's left for a release?
> > >Date: Tue, 22 Apr 2003 11:46:55 -0400
> > >
> > >Hello,
> > >
> > >Could you address why doing (2) only be an issue?
> > >
> > >It certainly would be fast task, I am volunteering of course!
> > >
> > >Thanks,
> > >Gary
> > >
> > >-----Original Message-----
> > >From: David Graham [mailto:dgraham1980@hotmail.com]
> > >Sent: Tuesday, April 22, 2003 8:44 AM
> > >To: commons-dev@jakarta.apache.org
> > >Subject: RE: [Pool] What's left for a release?
> > >
> > >-1 on changing this for 2.0.  Struts needs this release soon.
> > >
> > >David
> > >
> > >
> > > >Hello,
> > > >
> > > >Could we address 
>http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19192
> > > >for
> > > >2.0?
> > > >
> > > >This is not a simple issue but it is very important for our 
>application.
> > >I
> > > >see two issues raised in GenericObjectPool by 19192:
> > > >
> > > >(1) What is the "correct" or desired default behavior? If we need a
> > >release
> > > >very soon (to satisfy a Struts dependency for example), this would 
>argue
> > > >for
> > > >not changing the locking behavior without some serious unit tests 
>added
> > >in
> > > >this department. So, if time is of the essence, don't touch it, and 
>we
> > >can
> > > >discuss it post-2.0.
> > > >
> > > >(2) If we consider that a goal for the class GenericObjectPool is 
>that it
> > > >be
> > > >customizable on top of "configurable" (Javadoc comment), by which I 
>mean
> > > >extendable/subclassable, then we should change the protection of 
>fields
> > >and
> > > >methods from private to protected to allow for this to happen. This 
>is
> > >not
> > > >the first time that we have seen the suggestion that a feature/bug 
>could
> > > >have been addressed by subclassing but that in fact could not due to
> > > >field/method protection. (I am leaving aside the fact that one can 
>change
> > > >any code in [pool] and recompile).
> > > >
> > > >Thoughts?
> > > >
> > > >Gary
> > > >
> > > >-----Original Message-----
> > > >From: James Mitchell [mailto:jmitchell@apache.org]
> > > >Sent: Thursday, April 17, 2003 4:16 AM
> > > >To: jakarta-commons-dev@apache.org
> > > >Subject: [Pool] What's left for a release?
> > > >
> > > >Initial search in bugzilla for pool turned up 3 bugs (ok, 2 bugs and 
>1
> > > >Enhancement).  The 2 bugs that were there have patches available.
> > > >
> > > >I was wondering if there were any specific reasons (other than
> > > >time/resources)
> > > >that those patches had not been committed.
> > > >
> > > >We are pushing for a RC2 over in the Struts camp and we depend on a 
>new
> > > >release of Pool.  I'd like to help with this if I can.
> > > >
> > > >Your thoughts?
> > > >
> > > >
> > > >--
> > > >James Mitchell
> > > >Software Developer/Struts Evangelist
> > > >http://www.open-tools.org
> > > >
> > > >
> > > >
> > > >
> > > >---------------------------------------------------------------------
> > > >To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > > >For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> > >
> > >
> > >_________________________________________________________________
> > >MSN 8 helps eliminate e-mail viruses. Get 2 months FREE*.
> > >http://join.msn.com/?page=features/virus
> > >
> > >
> > >---------------------------------------------------------------------
> > >To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > >For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >
> >
> > _________________________________________________________________
> > Add photos to your e-mail with MSN 8. Get 2 months FREE*.
> > http://join.msn.com/?page=features/featuredemail
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>


_________________________________________________________________
MSN 8 helps eliminate e-mail viruses. Get 2 months FREE*.  
http://join.msn.com/?page=features/virus


---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org


Re: [Pool] What's left for a release?

Posted by Paul Speed <ps...@progeeks.com>.

Vic Cekvenich wrote:
> 
> "When all logical things are eliminated, we have to consider what's left."
> Isn't that captain Kirk or Spock or someone from Star Treck?

Way, way off topic at this point, but I'm pretty sure that it's a 
regurgitated Sherlock Holmes quote.  I can't be bothered to google
it though. ;)
-Paul

> 
> And I am soooo pro open source and not for M$.  Open Source has been
> good to me, and you can see nice Apache source license on sf.net
> 
> .V
> aka. double agent
>

---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org


Re: [Pool] What's left for a release?

Posted by Vic Cekvenich <vc...@basebeans.com>.
"When all logical things are eliminated, we have to consider what's left."
Isn't that captain Kirk or Spock or someone from Star Treck?

And I am soooo pro open source and not for M$.  Open Source has been 
good to me, and you can see nice Apache source license on sf.net

.V
aka. double agent


James Mitchell wrote:
> Vic, I find that hard to believe.  Especially considering the JSF
> integration build he recently uploaded.
> 
> Anyone else heard anything like that?
> 
> --
> James Mitchell
> Software Developer/Struts Evangelist
> http://www.open-tools.org
> 
> 
> 
> ----- Original Message -----
> From: "Vic Cekvenich" <vc...@basebeans.com>
> To: <st...@jakarta.apache.org>
> Sent: Tuesday, April 22, 2003 3:41 PM
> Subject: Re: [Pool] What's left for a release?
> 
> 
> 
>>I just came back from Europe .... there I heard a r from someone plugged
>>into Sun that Craig is holding back Struts, so JSF comes out. !!
>>
>>If this is true, than Craig has you chasing rabbits. He already gave
> 
>  a -1.
> 
>>Of course no facts but, if true, than not even M$ would do what Sun.
>>
>>.V
>>
>>David Graham wrote:
>>
>>>Struts does not use commons-pool directly, we inherit the dependency
>>>from our use of DBCP.  If you're comfortable with the change and it
>>>won't break DBCP (which we also need a release of), then I'm fine with
> 
> it.
> 
>>>We still haven't heard what variables subclasses need access to that
>>>don't already have accessors.
>>>
>>>David
>>>
>>>
>>>
>>>
>>>>From: Rodney Waldhoff <rw...@apache.org>
>>>>Reply-To: "Jakarta Commons Developers List"
>>>><co...@jakarta.apache.org>
>>>>To: Jakarta Commons Developers List <co...@jakarta.apache.org>
>>>>Subject: RE: [Pool] What's left for a release?
>>>>Date: Tue, 22 Apr 2003 11:12:20 -0700 (PDT)
>>>>
>>>>Ok, but you may not like all my answers.
>>>>
>>>>Regarding <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19192>, I
>>>>think I'm reasonably comfortable with making this change before the 2.0
>>>>release--this simply unsyncs the factory's makeObject method, which
>>>>shouldn't need to be locked by the pool anyway.  Also, addObject
>>>>stands in
>>>>isolation--none of the other pool methods invoke it, so this will only
>>>>impact those who "prepopulate" or otherwise add things to the pool
>>>>manually.  If struts doesn't do that, then maybe David will be more
>>>>comfortable with the change.  If it'll keep everyone happy, maybe we
>>>>should do a 2.0 release without that change and immediately follow it
> 
> up
> 
>>>>this change (either as a 2.0.1 or SNAPSHOT release).
>>>>
>>>>Regarding "allowing advanced use of [GenericObjectPool] by
>>>>subclassing", I
>>>>happen to have posted an article just yesterday (see
>>>>
> 
> <http://radio.weblogs.com/0122027/stories/2003/04/21/areConcreteParentClasse
> sACodeSmell.html>)
> 
>>>>that argues against concrete parent types. Honestly, I think the pool
> 
> API
> 
>>>>would be better served by some refactoring to better allow
> 
> customization
> 
>>>>via composition rather than inheritance.  The current design offers one
>>>>type of partitioning--separating the pool management from the object
>>>>lifecycle--but fails to support all the axes and degrees of variation
>>>>that
>>>>are desired.  I have some notes that discuss this in greater detail
>>>>that I
>>>>had originally intended to post as "proposal", but it began to seem
> 
> like
> 
>>>>it'd be easier just to check it in an let someone veto if they way.
>>>>Following the 2.0 release I'll try to do one or the other.
>>>>
>>>>- Rod <http://radio.weblogs.com/0122027/>
>>>>
>>>>On Tue, 22 Apr 2003, Gary Gregory wrote:
>>>>
>>>>
>>>>>Rodney,
>>>>>
>>>>>I see your name as the author for GenericObjectPool. Do you have any
>>>>>thoughts to share with us on this topic?
>>>>>
>>>>>Thanks,
>>>>>Gary
>>>>>
>>>>>-----Original Message-----
>>>>>From: Gary Gregory [mailto:ggregory@seagullsw.com]
>>>>>Sent: Tuesday, April 22, 2003 10:28 AM
>>>>>To: 'Jakarta Commons Developers List'
>>>>>Subject: RE: [Pool] What's left for a release?
>>>>>
>>>>>David,
>>>>>
>>>>>Well, here we could split this into two issues. I do not like (1)
>>>>
>>>>and I am
>>>>
>>>>>in favor for (2).
>>>>>
>>>>>(1) Which exact one field in GenericObjectPool would we need to
>>>>
>>>>change to
>>>>
>>>>>protected access to address our current problem? We could make this
> 
> one
> 
>>>>>field protected in 2.0. We could then create our own subclass and
>>>>
>>>>define the
>>>>
>>>>>behavior we need. You would end up with GenericObjectPool that has
>>>>
>>>>one ivar
>>>>
>>>>>protected and all others private, which is oddly inconsistent and
>>>>
>>>>needs to
>>>>
>>>>>be explained in the docs. The next time a problem shows up which
>>>>
>>>>/could/
>>>>
>>>>>have been solved with a subclass, we are back to where we started:
>>>>
>>>>You could
>>>>
>>>>>subclass if only field f was protected instead of private. I claim
>>>>
>>>>this is
>>>>
>>>>>not the way to go.
>>>>>
>>>>>(2) GenericObjectPool is a nice re-usable class, at runtime. As the
>>>>
>>>>Javadoc
>>>>
>>>>>states it is "configurable". My claim is that full reusability would
> 
> be
> 
>>>>>better served by allowing advanced use of the class via subclassing.
>>>>>
>>>>>Here, http://jakarta.apache.org/commons/pool/, states: "A generic
>>>>
>>>>object
>>>>
>>>>>pool interface that clients and implementors can use to provide
> 
> easily
> 
>>>>>interchangable pooling implementations." (Webmaster,
> 
> interchangable ->
> 
>>>>>interchangeable.)
>>>>>
>>>>>Well, we would like to be implementing our own pool to customize
>>>>
>>>>behavior in
>>>>
>>>>>GenericObjectPool, but we cannot. Hence the request to simply make
>>>>
>>>>fields
>>>>
>>>>>and methods that are now private protected. This would allow
>>>>
>>>>subclassing to
>>>>
>>>>>work, always. Why not solve this problem once?
>>>>>
>>>>>Thanks for taking the time to consider this issue, BTW.
>>>>>
>>>>>Gary
>>>>>
>>>>>PS: I cannot tell how many times this happens with third party
>>>>
>>>>code... GG.
>>>>
>>>>>-----Original Message-----
>>>>>From: David Graham [mailto:dgraham1980@hotmail.com]
>>>>>Sent: Tuesday, April 22, 2003 10:00 AM
>>>>>To: commons-dev@jakarta.apache.org
>>>>>Subject: RE: [Pool] What's left for a release?
>>>>>
>>>>>Specifically, which fields do you want protected access for that you
>>>>
>>>>can't
>>>>
>>>>>get to via accessors?
>>>>>
>>>>>David
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>>From: Gary Gregory <gg...@seagullsw.com>
>>>>>>Reply-To: "Jakarta Commons Developers List"
>>>>>><co...@jakarta.apache.org>
>>>>>>To: 'Jakarta Commons Developers List'
> 
> <co...@jakarta.apache.org>
> 
>>>>>>Subject: RE: [Pool] What's left for a release?
>>>>>>Date: Tue, 22 Apr 2003 11:46:55 -0400
>>>>>>
>>>>>>Hello,
>>>>>>
>>>>>>Could you address why doing (2) only be an issue?
>>>>>>
>>>>>>It certainly would be fast task, I am volunteering of course!
>>>>>>
>>>>>>Thanks,
>>>>>>Gary
>>>>>>
>>>>>>-----Original Message-----
>>>>>>From: David Graham [mailto:dgraham1980@hotmail.com]
>>>>>>Sent: Tuesday, April 22, 2003 8:44 AM
>>>>>>To: commons-dev@jakarta.apache.org
>>>>>>Subject: RE: [Pool] What's left for a release?
>>>>>>
>>>>>>-1 on changing this for 2.0.  Struts needs this release soon.
>>>>>>
>>>>>>David
>>>>>>
>>>>>>
>>>>>>
>>>>>>>Hello,
>>>>>>>
>>>>>>>Could we address
>>>>
>>>>http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19192
>>>>
>>>>>>>for
>>>>>>>2.0?
>>>>>>>
>>>>>>>This is not a simple issue but it is very important for our
>>>>
>>>>application.
>>>>
>>>>>>I
>>>>>>
>>>>>>>see two issues raised in GenericObjectPool by 19192:
>>>>>>>
>>>>>>>(1) What is the "correct" or desired default behavior? If we need
> 
> a
> 
>>>>>>release
>>>>>>
>>>>>>>very soon (to satisfy a Struts dependency for example), this
>>>>
>>>>would argue
>>>>
>>>>>>>for
>>>>>>>not changing the locking behavior without some serious unit tests
>>>>
>>>>added
>>>>
>>>>>>in
>>>>>>
>>>>>>>this department. So, if time is of the essence, don't touch it,
>>>>
>>>>and we
>>>>
>>>>>>can
>>>>>>
>>>>>>>discuss it post-2.0.
>>>>>>>
>>>>>>>(2) If we consider that a goal for the class GenericObjectPool is
>>>>
>>>>that it
>>>>
>>>>>>>be
>>>>>>>customizable on top of "configurable" (Javadoc comment), by which
>>>>
>>>>I mean
>>>>
>>>>>>>extendable/subclassable, then we should change the protection of
>>>>
>>>>fields
>>>>
>>>>>>and
>>>>>>
>>>>>>>methods from private to protected to allow for this to happen.
>>>>
>>>>This is
>>>>
>>>>>>not
>>>>>>
>>>>>>>the first time that we have seen the suggestion that a
>>>>
>>>>feature/bug could
>>>>
>>>>>>>have been addressed by subclassing but that in fact could not due
> 
> to
> 
>>>>>>>field/method protection. (I am leaving aside the fact that one
>>>>
>>>>can change
>>>>
>>>>>>>any code in [pool] and recompile).
>>>>>>>
>>>>>>>Thoughts?
>>>>>>>
>>>>>>>Gary
>>>>>>>
>>>>>>>-----Original Message-----
>>>>>>>From: James Mitchell [mailto:jmitchell@apache.org]
>>>>>>>Sent: Thursday, April 17, 2003 4:16 AM
>>>>>>>To: jakarta-commons-dev@apache.org
>>>>>>>Subject: [Pool] What's left for a release?
>>>>>>>
>>>>>>>Initial search in bugzilla for pool turned up 3 bugs (ok, 2 bugs
>>>>
>>>>and 1
>>>>
>>>>>>>Enhancement).  The 2 bugs that were there have patches available.
>>>>>>>
>>>>>>>I was wondering if there were any specific reasons (other than
>>>>>>>time/resources)
>>>>>>>that those patches had not been committed.
>>>>>>>
>>>>>>>We are pushing for a RC2 over in the Struts camp and we depend on
>>>>
>>>>a new
>>>>
>>>>>>>release of Pool.  I'd like to help with this if I can.
>>>>>>>
>>>>>>>Your thoughts?
>>>>>>>
>>>>>>>
>>>>>>>--
>>>>>>>James Mitchell
>>>>>>>Software Developer/Struts Evangelist
>>>>>>>http://www.open-tools.org
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>---------------------------------------------------------------------
>>>>>
>>>>>>>To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>>>>>>>For additional commands, e-mail:
> 
> commons-dev-help@jakarta.apache.org
> 
>>>>>>
>>>>>>_________________________________________________________________
>>>>>>MSN 8 helps eliminate e-mail viruses. Get 2 months FREE*.
>>>>>>http://join.msn.com/?page=features/virus
>>>>>>
>>>>>>
>>>>>
>>---------------------------------------------------------------------
>>
>>>>>>To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>>>>>>For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>>>>>
>>>>>
>>>>>_________________________________________________________________
>>>>>Add photos to your e-mail with MSN 8. Get 2 months FREE*.
>>>>>http://join.msn.com/?page=features/featuredemail
>>>>>
>>>>>
>>>>>---------------------------------------------------------------------
>>>>>To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>>>>>For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>>>>>
>>>>
>>>>---------------------------------------------------------------------
>>>>To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>>>>For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>>>>
>>>
>>>
>>>_________________________________________________________________
>>>MSN 8 helps eliminate e-mail viruses. Get 2 months FREE*.
>>>http://join.msn.com/?page=features/virus
>>
>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
>>For additional commands, e-mail: struts-dev-help@jakarta.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org


Re: [Pool] What's left for a release?

Posted by James Mitchell <jm...@apache.org>.
Vic, I find that hard to believe.  Especially considering the JSF
integration build he recently uploaded.

Anyone else heard anything like that?

--
James Mitchell
Software Developer/Struts Evangelist
http://www.open-tools.org



----- Original Message -----
From: "Vic Cekvenich" <vc...@basebeans.com>
To: <st...@jakarta.apache.org>
Sent: Tuesday, April 22, 2003 3:41 PM
Subject: Re: [Pool] What's left for a release?


> I just came back from Europe .... there I heard a r from someone plugged
> into Sun that Craig is holding back Struts, so JSF comes out. !!
>
> If this is true, than Craig has you chasing rabbits. He already gave
 a -1.
> Of course no facts but, if true, than not even M$ would do what Sun.
>
> .V
>
> David Graham wrote:
> > Struts does not use commons-pool directly, we inherit the dependency
> > from our use of DBCP.  If you're comfortable with the change and it
> > won't break DBCP (which we also need a release of), then I'm fine with
it.
> >
> > We still haven't heard what variables subclasses need access to that
> > don't already have accessors.
> >
> > David
> >
> >
> >
> >> From: Rodney Waldhoff <rw...@apache.org>
> >> Reply-To: "Jakarta Commons Developers List"
> >> <co...@jakarta.apache.org>
> >> To: Jakarta Commons Developers List <co...@jakarta.apache.org>
> >> Subject: RE: [Pool] What's left for a release?
> >> Date: Tue, 22 Apr 2003 11:12:20 -0700 (PDT)
> >>
> >> Ok, but you may not like all my answers.
> >>
> >> Regarding <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19192>, I
> >> think I'm reasonably comfortable with making this change before the 2.0
> >> release--this simply unsyncs the factory's makeObject method, which
> >> shouldn't need to be locked by the pool anyway.  Also, addObject
> >> stands in
> >> isolation--none of the other pool methods invoke it, so this will only
> >> impact those who "prepopulate" or otherwise add things to the pool
> >> manually.  If struts doesn't do that, then maybe David will be more
> >> comfortable with the change.  If it'll keep everyone happy, maybe we
> >> should do a 2.0 release without that change and immediately follow it
up
> >> this change (either as a 2.0.1 or SNAPSHOT release).
> >>
> >> Regarding "allowing advanced use of [GenericObjectPool] by
> >> subclassing", I
> >> happen to have posted an article just yesterday (see
> >>
<http://radio.weblogs.com/0122027/stories/2003/04/21/areConcreteParentClasse
sACodeSmell.html>)
> >>
> >> that argues against concrete parent types. Honestly, I think the pool
API
> >> would be better served by some refactoring to better allow
customization
> >> via composition rather than inheritance.  The current design offers one
> >> type of partitioning--separating the pool management from the object
> >> lifecycle--but fails to support all the axes and degrees of variation
> >> that
> >> are desired.  I have some notes that discuss this in greater detail
> >> that I
> >> had originally intended to post as "proposal", but it began to seem
like
> >> it'd be easier just to check it in an let someone veto if they way.
> >> Following the 2.0 release I'll try to do one or the other.
> >>
> >> - Rod <http://radio.weblogs.com/0122027/>
> >>
> >> On Tue, 22 Apr 2003, Gary Gregory wrote:
> >>
> >> > Rodney,
> >> >
> >> > I see your name as the author for GenericObjectPool. Do you have any
> >> > thoughts to share with us on this topic?
> >> >
> >> > Thanks,
> >> > Gary
> >> >
> >> > -----Original Message-----
> >> > From: Gary Gregory [mailto:ggregory@seagullsw.com]
> >> > Sent: Tuesday, April 22, 2003 10:28 AM
> >> > To: 'Jakarta Commons Developers List'
> >> > Subject: RE: [Pool] What's left for a release?
> >> >
> >> > David,
> >> >
> >> > Well, here we could split this into two issues. I do not like (1)
> >> and I am
> >> > in favor for (2).
> >> >
> >> > (1) Which exact one field in GenericObjectPool would we need to
> >> change to
> >> > protected access to address our current problem? We could make this
one
> >> > field protected in 2.0. We could then create our own subclass and
> >> define the
> >> > behavior we need. You would end up with GenericObjectPool that has
> >> one ivar
> >> > protected and all others private, which is oddly inconsistent and
> >> needs to
> >> > be explained in the docs. The next time a problem shows up which
> >> /could/
> >> > have been solved with a subclass, we are back to where we started:
> >> You could
> >> > subclass if only field f was protected instead of private. I claim
> >> this is
> >> > not the way to go.
> >> >
> >> > (2) GenericObjectPool is a nice re-usable class, at runtime. As the
> >> Javadoc
> >> > states it is "configurable". My claim is that full reusability would
be
> >> > better served by allowing advanced use of the class via subclassing.
> >> >
> >> > Here, http://jakarta.apache.org/commons/pool/, states: "A generic
> >> object
> >> > pool interface that clients and implementors can use to provide
easily
> >> > interchangable pooling implementations." (Webmaster,
interchangable ->
> >> > interchangeable.)
> >> >
> >> > Well, we would like to be implementing our own pool to customize
> >> behavior in
> >> > GenericObjectPool, but we cannot. Hence the request to simply make
> >> fields
> >> > and methods that are now private protected. This would allow
> >> subclassing to
> >> > work, always. Why not solve this problem once?
> >> >
> >> > Thanks for taking the time to consider this issue, BTW.
> >> >
> >> > Gary
> >> >
> >> > PS: I cannot tell how many times this happens with third party
> >> code... GG.
> >> >
> >> > -----Original Message-----
> >> > From: David Graham [mailto:dgraham1980@hotmail.com]
> >> > Sent: Tuesday, April 22, 2003 10:00 AM
> >> > To: commons-dev@jakarta.apache.org
> >> > Subject: RE: [Pool] What's left for a release?
> >> >
> >> > Specifically, which fields do you want protected access for that you
> >> can't
> >> > get to via accessors?
> >> >
> >> > David
> >> >
> >> >
> >> >
> >> > >From: Gary Gregory <gg...@seagullsw.com>
> >> > >Reply-To: "Jakarta Commons Developers List"
> >> > ><co...@jakarta.apache.org>
> >> > >To: 'Jakarta Commons Developers List'
<co...@jakarta.apache.org>
> >> > >Subject: RE: [Pool] What's left for a release?
> >> > >Date: Tue, 22 Apr 2003 11:46:55 -0400
> >> > >
> >> > >Hello,
> >> > >
> >> > >Could you address why doing (2) only be an issue?
> >> > >
> >> > >It certainly would be fast task, I am volunteering of course!
> >> > >
> >> > >Thanks,
> >> > >Gary
> >> > >
> >> > >-----Original Message-----
> >> > >From: David Graham [mailto:dgraham1980@hotmail.com]
> >> > >Sent: Tuesday, April 22, 2003 8:44 AM
> >> > >To: commons-dev@jakarta.apache.org
> >> > >Subject: RE: [Pool] What's left for a release?
> >> > >
> >> > >-1 on changing this for 2.0.  Struts needs this release soon.
> >> > >
> >> > >David
> >> > >
> >> > >
> >> > > >Hello,
> >> > > >
> >> > > >Could we address
> >> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19192
> >> > > >for
> >> > > >2.0?
> >> > > >
> >> > > >This is not a simple issue but it is very important for our
> >> application.
> >> > >I
> >> > > >see two issues raised in GenericObjectPool by 19192:
> >> > > >
> >> > > >(1) What is the "correct" or desired default behavior? If we need
a
> >> > >release
> >> > > >very soon (to satisfy a Struts dependency for example), this
> >> would argue
> >> > > >for
> >> > > >not changing the locking behavior without some serious unit tests
> >> added
> >> > >in
> >> > > >this department. So, if time is of the essence, don't touch it,
> >> and we
> >> > >can
> >> > > >discuss it post-2.0.
> >> > > >
> >> > > >(2) If we consider that a goal for the class GenericObjectPool is
> >> that it
> >> > > >be
> >> > > >customizable on top of "configurable" (Javadoc comment), by which
> >> I mean
> >> > > >extendable/subclassable, then we should change the protection of
> >> fields
> >> > >and
> >> > > >methods from private to protected to allow for this to happen.
> >> This is
> >> > >not
> >> > > >the first time that we have seen the suggestion that a
> >> feature/bug could
> >> > > >have been addressed by subclassing but that in fact could not due
to
> >> > > >field/method protection. (I am leaving aside the fact that one
> >> can change
> >> > > >any code in [pool] and recompile).
> >> > > >
> >> > > >Thoughts?
> >> > > >
> >> > > >Gary
> >> > > >
> >> > > >-----Original Message-----
> >> > > >From: James Mitchell [mailto:jmitchell@apache.org]
> >> > > >Sent: Thursday, April 17, 2003 4:16 AM
> >> > > >To: jakarta-commons-dev@apache.org
> >> > > >Subject: [Pool] What's left for a release?
> >> > > >
> >> > > >Initial search in bugzilla for pool turned up 3 bugs (ok, 2 bugs
> >> and 1
> >> > > >Enhancement).  The 2 bugs that were there have patches available.
> >> > > >
> >> > > >I was wondering if there were any specific reasons (other than
> >> > > >time/resources)
> >> > > >that those patches had not been committed.
> >> > > >
> >> > > >We are pushing for a RC2 over in the Struts camp and we depend on
> >> a new
> >> > > >release of Pool.  I'd like to help with this if I can.
> >> > > >
> >> > > >Your thoughts?
> >> > > >
> >> > > >
> >> > > >--
> >> > > >James Mitchell
> >> > > >Software Developer/Struts Evangelist
> >> > > >http://www.open-tools.org
> >> > > >
> >> > > >
> >> > > >
> >> > > >
> >> > >
> >> >---------------------------------------------------------------------
> >> > > >To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> >> > > >For additional commands, e-mail:
commons-dev-help@jakarta.apache.org
> >> > >
> >> > >
> >> > >_________________________________________________________________
> >> > >MSN 8 helps eliminate e-mail viruses. Get 2 months FREE*.
> >> > >http://join.msn.com/?page=features/virus
> >> > >
> >> > >
> >> >
>---------------------------------------------------------------------
> >> > >To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> >> > >For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >> >
> >> >
> >> > _________________________________________________________________
> >> > Add photos to your e-mail with MSN 8. Get 2 months FREE*.
> >> > http://join.msn.com/?page=features/featuredemail
> >> >
> >> >
> >> > ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> >> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >> >
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> >> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >>
> >
> >
> > _________________________________________________________________
> > MSN 8 helps eliminate e-mail viruses. Get 2 months FREE*.
> > http://join.msn.com/?page=features/virus
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: struts-dev-help@jakarta.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org


RE: [Pool] What's left for a release?

Posted by Andrew Hill <an...@gridnode.com>.
Now you see what your little 'dispute' has done
-You've scared away one of the users!
Shame on you.

;->

-----Original Message-----
From: Pradeepta [mailto:pradeepta.b@passindien.com]
Sent: Thursday, 24 April 2003 12:09
To: 'Struts Developers List'
Subject: RE: [Pool] What's left for a release?


Kindly Unsubscribe me .... thanks in advance

Kind Regards,
Pradeepta Bhattacharya,
Software Developer,
PASS IT Consulting Pvt. Ltd.
Paigah Plaza, Basheer Bagh
Hyderabad - 29 .
Andhra Pradesh, India.
Email : Pradeepta.Bhattacharya@pass-consulting.com
 Tel (office) : 91 - 40 - 6625045 / 46
         (Res) : 91 - 40 - 7014530
URL: www.pass-consulting.com


-----Original Message-----
From: news [mailto:news@main.gmane.org] On Behalf Of Vic Cekvenich
Sent: Wednesday, April 23, 2003 8:32 PM
To: struts-dev@jakarta.apache.org
Subject: Re: [Pool] What's left for a release?

Maybe we can e-mail each other private then, so no flame war.

My clients hire me because I code quick, and I can show them how to code

quick.

They also hire me because I recommend things that are good, and will
tell them vendor independent, if I think EJBs are a good idea, even if I

get vendor backlash - as per you private e-mail 6 months back.

.V


Craig R. McClanahan wrote:
>
> On Tue, 22 Apr 2003, Vic Cekvenich wrote:
>
>
>>Date: Tue, 22 Apr 2003 15:41:54 -0400
>>From: Vic Cekvenich <vc...@basebeans.com>
>>Reply-To: Struts Developers List <st...@jakarta.apache.org>
>>To: struts-dev@jakarta.apache.org
>>Subject: Re: [Pool] What's left for a release?
>>
>>I just came back from Europe .... there I heard a r from someone
plugged
>>into Sun that Craig is holding back Struts, so JSF comes out. !!
>>
>
>
> Just getting back from two weeks of vacation last night (jet-lagged
today,
> as it happens I was also in Europe) ... and it didn't take very many
email
> messages to get me a huge laugh -- thanks for that :-).
>
>
>>If this is true, than Craig has you chasing rabbits. He already gave
a -1.
>>Of course no facts but, if true, than not even M$ would do what Sun.
>>
>
>
> Vic, you should really post "the enemy within" stuff like this on a
> private blog, or at least someplace other than a very widely read
Struts
> mailing list -- that way you'll make a fool of yourself in front of a
> *lot* fewer people -- especially considering that you are doing so in
> front of many of the people that might consider purchasing your
services.
>
>
>>.V
>
>
> Craig



---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org


RE: [Pool] What's left for a release?

Posted by Pradeepta <pr...@passindien.com>.
Kindly Unsubscribe me .... thanks in advance

Kind Regards,
Pradeepta Bhattacharya,
Software Developer,
PASS IT Consulting Pvt. Ltd.
Paigah Plaza, Basheer Bagh
Hyderabad - 29 .
Andhra Pradesh, India.
Email : Pradeepta.Bhattacharya@pass-consulting.com
 Tel (office) : 91 - 40 - 6625045 / 46 
         (Res) : 91 - 40 - 7014530
URL: www.pass-consulting.com


-----Original Message-----
From: news [mailto:news@main.gmane.org] On Behalf Of Vic Cekvenich
Sent: Wednesday, April 23, 2003 8:32 PM
To: struts-dev@jakarta.apache.org
Subject: Re: [Pool] What's left for a release?

Maybe we can e-mail each other private then, so no flame war.

My clients hire me because I code quick, and I can show them how to code

quick.

They also hire me because I recommend things that are good, and will 
tell them vendor independent, if I think EJBs are a good idea, even if I

get vendor backlash - as per you private e-mail 6 months back.

.V


Craig R. McClanahan wrote:
> 
> On Tue, 22 Apr 2003, Vic Cekvenich wrote:
> 
> 
>>Date: Tue, 22 Apr 2003 15:41:54 -0400
>>From: Vic Cekvenich <vc...@basebeans.com>
>>Reply-To: Struts Developers List <st...@jakarta.apache.org>
>>To: struts-dev@jakarta.apache.org
>>Subject: Re: [Pool] What's left for a release?
>>
>>I just came back from Europe .... there I heard a r from someone
plugged
>>into Sun that Craig is holding back Struts, so JSF comes out. !!
>>
> 
> 
> Just getting back from two weeks of vacation last night (jet-lagged
today,
> as it happens I was also in Europe) ... and it didn't take very many
email
> messages to get me a huge laugh -- thanks for that :-).
> 
> 
>>If this is true, than Craig has you chasing rabbits. He already gave
a -1.
>>Of course no facts but, if true, than not even M$ would do what Sun.
>>
> 
> 
> Vic, you should really post "the enemy within" stuff like this on a
> private blog, or at least someplace other than a very widely read
Struts
> mailing list -- that way you'll make a fool of yourself in front of a
> *lot* fewer people -- especially considering that you are doing so in
> front of many of the people that might consider purchasing your
services.
> 
> 
>>.V
> 
> 
> Craig



---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org


Re: [Pool] What's left for a release?

Posted by Vic Cekvenich <vc...@basebeans.com>.
Maybe we can e-mail each other private then, so no flame war.

My clients hire me because I code quick, and I can show them how to code 
quick.

They also hire me because I recommend things that are good, and will 
tell them vendor independent, if I think EJBs are a good idea, even if I 
get vendor backlash - as per you private e-mail 6 months back.

.V


Craig R. McClanahan wrote:
> 
> On Tue, 22 Apr 2003, Vic Cekvenich wrote:
> 
> 
>>Date: Tue, 22 Apr 2003 15:41:54 -0400
>>From: Vic Cekvenich <vc...@basebeans.com>
>>Reply-To: Struts Developers List <st...@jakarta.apache.org>
>>To: struts-dev@jakarta.apache.org
>>Subject: Re: [Pool] What's left for a release?
>>
>>I just came back from Europe .... there I heard a r from someone plugged
>>into Sun that Craig is holding back Struts, so JSF comes out. !!
>>
> 
> 
> Just getting back from two weeks of vacation last night (jet-lagged today,
> as it happens I was also in Europe) ... and it didn't take very many email
> messages to get me a huge laugh -- thanks for that :-).
> 
> 
>>If this is true, than Craig has you chasing rabbits. He already gave  a -1.
>>Of course no facts but, if true, than not even M$ would do what Sun.
>>
> 
> 
> Vic, you should really post "the enemy within" stuff like this on a
> private blog, or at least someplace other than a very widely read Struts
> mailing list -- that way you'll make a fool of yourself in front of a
> *lot* fewer people -- especially considering that you are doing so in
> front of many of the people that might consider purchasing your services.
> 
> 
>>.V
> 
> 
> Craig



---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org


Re: [Pool] What's left for a release?

Posted by "Craig R. McClanahan" <cr...@apache.org>.

On Tue, 22 Apr 2003, Vic Cekvenich wrote:

> Date: Tue, 22 Apr 2003 15:41:54 -0400
> From: Vic Cekvenich <vc...@basebeans.com>
> Reply-To: Struts Developers List <st...@jakarta.apache.org>
> To: struts-dev@jakarta.apache.org
> Subject: Re: [Pool] What's left for a release?
>
> I just came back from Europe .... there I heard a r from someone plugged
> into Sun that Craig is holding back Struts, so JSF comes out. !!
>

Just getting back from two weeks of vacation last night (jet-lagged today,
as it happens I was also in Europe) ... and it didn't take very many email
messages to get me a huge laugh -- thanks for that :-).

> If this is true, than Craig has you chasing rabbits. He already gave  a -1.
> Of course no facts but, if true, than not even M$ would do what Sun.
>

Vic, you should really post "the enemy within" stuff like this on a
private blog, or at least someplace other than a very widely read Struts
mailing list -- that way you'll make a fool of yourself in front of a
*lot* fewer people -- especially considering that you are doing so in
front of many of the people that might consider purchasing your services.

> .V

Craig

---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org


Re: [Pool] What's left for a release?

Posted by Ted Husted <hu...@apache.org>.
It's not possible for any one person to hold up the release of Struts. 
Once there is a release manager, everything is by majority. No one 
person can "veto" a release.

The problem we have now is that we've integrated a number of packages 
into the Struts core, and it's hard for any one person to stay up with 
all the code in all these packages. That decision was made over a year 
ago and has nothing to do with anything else that is going on now.

It's true that we should have made an interim release of Struts over a 
year ago, before getting into modules. That was suggested, but more than 
one committer thought the modules stuff would sail pretty quickly.

Once we put the modules in, then we decided to integrate Tiles and the 
Validator so that they would have module support. Again, we should have 
made a point release before doing that, but integrating Tiles and the 
Validator proved a harder road than imagined.

Meanwhile, being good Jakarta citizens, we began migrating more and more 
of our code to the Commons. In general, this should not be a problem, 
since it is as easy for us to work in that CVS as it is to work in this 
one. But, now we need to release components there before we can release 
our dependent code here. The big stumbling block had been the DBCP, 
which most of us have not been involved with directly. But, the DBCP is 
an important component (it is why we have a Commons in the first 
place!). It is being used by other products, like Hibernate, and it does 
make sense for us to use it as well.

That Struts 1.1 has not been released do not benefit anyone in the Java 
community. The best thing for everyone would be to make more point 
releases of Struts that integrate new technologies as they become 
available. The only one benefiting from the current SNAFU is .NET.

Once we get over this stumbling block, I can personally guarantee that 
it won't happen again. If there is a significant commit when we have 
other features that we could ship first, I will be the first to veto 
such a product change and insist that we ship what we got before 
starting on something new. But, for now, the die is cast.

-Ted.

-- 
Ted Husted,
Struts in Action <http://husted.com/struts/book.html>



---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org


Re: [Pool] What's left for a release?

Posted by Martin Cooper <ma...@apache.org>.
"Vic Cekvenich" <vc...@basebeans.com> wrote in message
news:b845sg$bmu$1@main.gmane.org...
> I just came back from Europe .... there I heard a r from someone plugged
> into Sun that Craig is holding back Struts, so JSF comes out. !!
>
> If this is true, than Craig has you chasing rabbits. He already gave
 a -1.
> Of course no facts but, if true, than not even M$ would do what Sun.

I have just one word for you, Vic -- hogwash.

--
Martin Cooper


>
> .V
>
> David Graham wrote:
> > Struts does not use commons-pool directly, we inherit the dependency
> > from our use of DBCP.  If you're comfortable with the change and it
> > won't break DBCP (which we also need a release of), then I'm fine with
it.
> >
> > We still haven't heard what variables subclasses need access to that
> > don't already have accessors.
> >
> > David
> >
> >
> >
> >> From: Rodney Waldhoff <rw...@apache.org>
> >> Reply-To: "Jakarta Commons Developers List"
> >> <co...@jakarta.apache.org>
> >> To: Jakarta Commons Developers List <co...@jakarta.apache.org>
> >> Subject: RE: [Pool] What's left for a release?
> >> Date: Tue, 22 Apr 2003 11:12:20 -0700 (PDT)
> >>
> >> Ok, but you may not like all my answers.
> >>
> >> Regarding <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19192>, I
> >> think I'm reasonably comfortable with making this change before the 2.0
> >> release--this simply unsyncs the factory's makeObject method, which
> >> shouldn't need to be locked by the pool anyway.  Also, addObject
> >> stands in
> >> isolation--none of the other pool methods invoke it, so this will only
> >> impact those who "prepopulate" or otherwise add things to the pool
> >> manually.  If struts doesn't do that, then maybe David will be more
> >> comfortable with the change.  If it'll keep everyone happy, maybe we
> >> should do a 2.0 release without that change and immediately follow it
up
> >> this change (either as a 2.0.1 or SNAPSHOT release).
> >>
> >> Regarding "allowing advanced use of [GenericObjectPool] by
> >> subclassing", I
> >> happen to have posted an article just yesterday (see
> >>
<http://radio.weblogs.com/0122027/stories/2003/04/21/areConcreteParentClasse
sACodeSmell.html>)
> >>
> >> that argues against concrete parent types. Honestly, I think the pool
API
> >> would be better served by some refactoring to better allow
customization
> >> via composition rather than inheritance.  The current design offers one
> >> type of partitioning--separating the pool management from the object
> >> lifecycle--but fails to support all the axes and degrees of variation
> >> that
> >> are desired.  I have some notes that discuss this in greater detail
> >> that I
> >> had originally intended to post as "proposal", but it began to seem
like
> >> it'd be easier just to check it in an let someone veto if they way.
> >> Following the 2.0 release I'll try to do one or the other.
> >>
> >> - Rod <http://radio.weblogs.com/0122027/>
> >>
> >> On Tue, 22 Apr 2003, Gary Gregory wrote:
> >>
> >> > Rodney,
> >> >
> >> > I see your name as the author for GenericObjectPool. Do you have any
> >> > thoughts to share with us on this topic?
> >> >
> >> > Thanks,
> >> > Gary
> >> >
> >> > -----Original Message-----
> >> > From: Gary Gregory [mailto:ggregory@seagullsw.com]
> >> > Sent: Tuesday, April 22, 2003 10:28 AM
> >> > To: 'Jakarta Commons Developers List'
> >> > Subject: RE: [Pool] What's left for a release?
> >> >
> >> > David,
> >> >
> >> > Well, here we could split this into two issues. I do not like (1)
> >> and I am
> >> > in favor for (2).
> >> >
> >> > (1) Which exact one field in GenericObjectPool would we need to
> >> change to
> >> > protected access to address our current problem? We could make this
one
> >> > field protected in 2.0. We could then create our own subclass and
> >> define the
> >> > behavior we need. You would end up with GenericObjectPool that has
> >> one ivar
> >> > protected and all others private, which is oddly inconsistent and
> >> needs to
> >> > be explained in the docs. The next time a problem shows up which
> >> /could/
> >> > have been solved with a subclass, we are back to where we started:
> >> You could
> >> > subclass if only field f was protected instead of private. I claim
> >> this is
> >> > not the way to go.
> >> >
> >> > (2) GenericObjectPool is a nice re-usable class, at runtime. As the
> >> Javadoc
> >> > states it is "configurable". My claim is that full reusability would
be
> >> > better served by allowing advanced use of the class via subclassing.
> >> >
> >> > Here, http://jakarta.apache.org/commons/pool/, states: "A generic
> >> object
> >> > pool interface that clients and implementors can use to provide
easily
> >> > interchangable pooling implementations." (Webmaster,
interchangable ->
> >> > interchangeable.)
> >> >
> >> > Well, we would like to be implementing our own pool to customize
> >> behavior in
> >> > GenericObjectPool, but we cannot. Hence the request to simply make
> >> fields
> >> > and methods that are now private protected. This would allow
> >> subclassing to
> >> > work, always. Why not solve this problem once?
> >> >
> >> > Thanks for taking the time to consider this issue, BTW.
> >> >
> >> > Gary
> >> >
> >> > PS: I cannot tell how many times this happens with third party
> >> code... GG.
> >> >
> >> > -----Original Message-----
> >> > From: David Graham [mailto:dgraham1980@hotmail.com]
> >> > Sent: Tuesday, April 22, 2003 10:00 AM
> >> > To: commons-dev@jakarta.apache.org
> >> > Subject: RE: [Pool] What's left for a release?
> >> >
> >> > Specifically, which fields do you want protected access for that you
> >> can't
> >> > get to via accessors?
> >> >
> >> > David
> >> >
> >> >
> >> >
> >> > >From: Gary Gregory <gg...@seagullsw.com>
> >> > >Reply-To: "Jakarta Commons Developers List"
> >> > ><co...@jakarta.apache.org>
> >> > >To: 'Jakarta Commons Developers List'
<co...@jakarta.apache.org>
> >> > >Subject: RE: [Pool] What's left for a release?
> >> > >Date: Tue, 22 Apr 2003 11:46:55 -0400
> >> > >
> >> > >Hello,
> >> > >
> >> > >Could you address why doing (2) only be an issue?
> >> > >
> >> > >It certainly would be fast task, I am volunteering of course!
> >> > >
> >> > >Thanks,
> >> > >Gary
> >> > >
> >> > >-----Original Message-----
> >> > >From: David Graham [mailto:dgraham1980@hotmail.com]
> >> > >Sent: Tuesday, April 22, 2003 8:44 AM
> >> > >To: commons-dev@jakarta.apache.org
> >> > >Subject: RE: [Pool] What's left for a release?
> >> > >
> >> > >-1 on changing this for 2.0.  Struts needs this release soon.
> >> > >
> >> > >David
> >> > >
> >> > >
> >> > > >Hello,
> >> > > >
> >> > > >Could we address
> >> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19192
> >> > > >for
> >> > > >2.0?
> >> > > >
> >> > > >This is not a simple issue but it is very important for our
> >> application.
> >> > >I
> >> > > >see two issues raised in GenericObjectPool by 19192:
> >> > > >
> >> > > >(1) What is the "correct" or desired default behavior? If we need
a
> >> > >release
> >> > > >very soon (to satisfy a Struts dependency for example), this
> >> would argue
> >> > > >for
> >> > > >not changing the locking behavior without some serious unit tests
> >> added
> >> > >in
> >> > > >this department. So, if time is of the essence, don't touch it,
> >> and we
> >> > >can
> >> > > >discuss it post-2.0.
> >> > > >
> >> > > >(2) If we consider that a goal for the class GenericObjectPool is
> >> that it
> >> > > >be
> >> > > >customizable on top of "configurable" (Javadoc comment), by which
> >> I mean
> >> > > >extendable/subclassable, then we should change the protection of
> >> fields
> >> > >and
> >> > > >methods from private to protected to allow for this to happen.
> >> This is
> >> > >not
> >> > > >the first time that we have seen the suggestion that a
> >> feature/bug could
> >> > > >have been addressed by subclassing but that in fact could not due
to
> >> > > >field/method protection. (I am leaving aside the fact that one
> >> can change
> >> > > >any code in [pool] and recompile).
> >> > > >
> >> > > >Thoughts?
> >> > > >
> >> > > >Gary
> >> > > >
> >> > > >-----Original Message-----
> >> > > >From: James Mitchell [mailto:jmitchell@apache.org]
> >> > > >Sent: Thursday, April 17, 2003 4:16 AM
> >> > > >To: jakarta-commons-dev@apache.org
> >> > > >Subject: [Pool] What's left for a release?
> >> > > >
> >> > > >Initial search in bugzilla for pool turned up 3 bugs (ok, 2 bugs
> >> and 1
> >> > > >Enhancement).  The 2 bugs that were there have patches available.
> >> > > >
> >> > > >I was wondering if there were any specific reasons (other than
> >> > > >time/resources)
> >> > > >that those patches had not been committed.
> >> > > >
> >> > > >We are pushing for a RC2 over in the Struts camp and we depend on
> >> a new
> >> > > >release of Pool.  I'd like to help with this if I can.
> >> > > >
> >> > > >Your thoughts?
> >> > > >
> >> > > >
> >> > > >--
> >> > > >James Mitchell
> >> > > >Software Developer/Struts Evangelist
> >> > > >http://www.open-tools.org
> >> > > >
> >> > > >
> >> > > >
> >> > > >
> >> > >
> >> >---------------------------------------------------------------------
> >> > > >To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> >> > > >For additional commands, e-mail:
commons-dev-help@jakarta.apache.org
> >> > >
> >> > >
> >> > >_________________________________________________________________
> >> > >MSN 8 helps eliminate e-mail viruses. Get 2 months FREE*.
> >> > >http://join.msn.com/?page=features/virus
> >> > >
> >> > >
> >> >
>---------------------------------------------------------------------
> >> > >To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> >> > >For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >> >
> >> >
> >> > _________________________________________________________________
> >> > Add photos to your e-mail with MSN 8. Get 2 months FREE*.
> >> > http://join.msn.com/?page=features/featuredemail
> >> >
> >> >
> >> > ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> >> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >> >
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> >> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >>
> >
> >
> > _________________________________________________________________
> > MSN 8 helps eliminate e-mail viruses. Get 2 months FREE*.
> > http://join.msn.com/?page=features/virus




---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org


RE: [Pool] What's left for a release?

Posted by Gary Ashley <st...@3rdMillenniumVisions.com>.
Vic Cekvenich wrote: 
> I just came back from Europe .... there I heard a r from someone
plugged 
> into Sun that Craig is holding back Struts, so JSF comes out. !!

If he is plugged in, please ask him to turn ON the light.  Maybe he is
just a M$ "bug".  





---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org


Re: [Pool] What's left for a release?

Posted by Vic Cekvenich <vc...@basebeans.com>.
I just came back from Europe .... there I heard a r from someone plugged 
into Sun that Craig is holding back Struts, so JSF comes out. !!

If this is true, than Craig has you chasing rabbits. He already gave  a -1.
Of course no facts but, if true, than not even M$ would do what Sun.

.V

David Graham wrote:
> Struts does not use commons-pool directly, we inherit the dependency 
> from our use of DBCP.  If you're comfortable with the change and it 
> won't break DBCP (which we also need a release of), then I'm fine with it.
> 
> We still haven't heard what variables subclasses need access to that 
> don't already have accessors.
> 
> David
> 
> 
> 
>> From: Rodney Waldhoff <rw...@apache.org>
>> Reply-To: "Jakarta Commons Developers List" 
>> <co...@jakarta.apache.org>
>> To: Jakarta Commons Developers List <co...@jakarta.apache.org>
>> Subject: RE: [Pool] What's left for a release?
>> Date: Tue, 22 Apr 2003 11:12:20 -0700 (PDT)
>>
>> Ok, but you may not like all my answers.
>>
>> Regarding <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19192>, I
>> think I'm reasonably comfortable with making this change before the 2.0
>> release--this simply unsyncs the factory's makeObject method, which
>> shouldn't need to be locked by the pool anyway.  Also, addObject 
>> stands in
>> isolation--none of the other pool methods invoke it, so this will only
>> impact those who "prepopulate" or otherwise add things to the pool
>> manually.  If struts doesn't do that, then maybe David will be more
>> comfortable with the change.  If it'll keep everyone happy, maybe we
>> should do a 2.0 release without that change and immediately follow it up
>> this change (either as a 2.0.1 or SNAPSHOT release).
>>
>> Regarding "allowing advanced use of [GenericObjectPool] by 
>> subclassing", I
>> happen to have posted an article just yesterday (see
>> <http://radio.weblogs.com/0122027/stories/2003/04/21/areConcreteParentClassesACodeSmell.html>) 
>>
>> that argues against concrete parent types. Honestly, I think the pool API
>> would be better served by some refactoring to better allow customization
>> via composition rather than inheritance.  The current design offers one
>> type of partitioning--separating the pool management from the object
>> lifecycle--but fails to support all the axes and degrees of variation 
>> that
>> are desired.  I have some notes that discuss this in greater detail 
>> that I
>> had originally intended to post as "proposal", but it began to seem like
>> it'd be easier just to check it in an let someone veto if they way.
>> Following the 2.0 release I'll try to do one or the other.
>>
>> - Rod <http://radio.weblogs.com/0122027/>
>>
>> On Tue, 22 Apr 2003, Gary Gregory wrote:
>>
>> > Rodney,
>> >
>> > I see your name as the author for GenericObjectPool. Do you have any
>> > thoughts to share with us on this topic?
>> >
>> > Thanks,
>> > Gary
>> >
>> > -----Original Message-----
>> > From: Gary Gregory [mailto:ggregory@seagullsw.com]
>> > Sent: Tuesday, April 22, 2003 10:28 AM
>> > To: 'Jakarta Commons Developers List'
>> > Subject: RE: [Pool] What's left for a release?
>> >
>> > David,
>> >
>> > Well, here we could split this into two issues. I do not like (1) 
>> and I am
>> > in favor for (2).
>> >
>> > (1) Which exact one field in GenericObjectPool would we need to 
>> change to
>> > protected access to address our current problem? We could make this one
>> > field protected in 2.0. We could then create our own subclass and 
>> define the
>> > behavior we need. You would end up with GenericObjectPool that has 
>> one ivar
>> > protected and all others private, which is oddly inconsistent and 
>> needs to
>> > be explained in the docs. The next time a problem shows up which 
>> /could/
>> > have been solved with a subclass, we are back to where we started: 
>> You could
>> > subclass if only field f was protected instead of private. I claim 
>> this is
>> > not the way to go.
>> >
>> > (2) GenericObjectPool is a nice re-usable class, at runtime. As the 
>> Javadoc
>> > states it is "configurable". My claim is that full reusability would be
>> > better served by allowing advanced use of the class via subclassing.
>> >
>> > Here, http://jakarta.apache.org/commons/pool/, states: "A generic 
>> object
>> > pool interface that clients and implementors can use to provide easily
>> > interchangable pooling implementations." (Webmaster, interchangable ->
>> > interchangeable.)
>> >
>> > Well, we would like to be implementing our own pool to customize 
>> behavior in
>> > GenericObjectPool, but we cannot. Hence the request to simply make 
>> fields
>> > and methods that are now private protected. This would allow 
>> subclassing to
>> > work, always. Why not solve this problem once?
>> >
>> > Thanks for taking the time to consider this issue, BTW.
>> >
>> > Gary
>> >
>> > PS: I cannot tell how many times this happens with third party 
>> code... GG.
>> >
>> > -----Original Message-----
>> > From: David Graham [mailto:dgraham1980@hotmail.com]
>> > Sent: Tuesday, April 22, 2003 10:00 AM
>> > To: commons-dev@jakarta.apache.org
>> > Subject: RE: [Pool] What's left for a release?
>> >
>> > Specifically, which fields do you want protected access for that you 
>> can't
>> > get to via accessors?
>> >
>> > David
>> >
>> >
>> >
>> > >From: Gary Gregory <gg...@seagullsw.com>
>> > >Reply-To: "Jakarta Commons Developers List"
>> > ><co...@jakarta.apache.org>
>> > >To: 'Jakarta Commons Developers List' <co...@jakarta.apache.org>
>> > >Subject: RE: [Pool] What's left for a release?
>> > >Date: Tue, 22 Apr 2003 11:46:55 -0400
>> > >
>> > >Hello,
>> > >
>> > >Could you address why doing (2) only be an issue?
>> > >
>> > >It certainly would be fast task, I am volunteering of course!
>> > >
>> > >Thanks,
>> > >Gary
>> > >
>> > >-----Original Message-----
>> > >From: David Graham [mailto:dgraham1980@hotmail.com]
>> > >Sent: Tuesday, April 22, 2003 8:44 AM
>> > >To: commons-dev@jakarta.apache.org
>> > >Subject: RE: [Pool] What's left for a release?
>> > >
>> > >-1 on changing this for 2.0.  Struts needs this release soon.
>> > >
>> > >David
>> > >
>> > >
>> > > >Hello,
>> > > >
>> > > >Could we address 
>> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19192
>> > > >for
>> > > >2.0?
>> > > >
>> > > >This is not a simple issue but it is very important for our 
>> application.
>> > >I
>> > > >see two issues raised in GenericObjectPool by 19192:
>> > > >
>> > > >(1) What is the "correct" or desired default behavior? If we need a
>> > >release
>> > > >very soon (to satisfy a Struts dependency for example), this 
>> would argue
>> > > >for
>> > > >not changing the locking behavior without some serious unit tests 
>> added
>> > >in
>> > > >this department. So, if time is of the essence, don't touch it, 
>> and we
>> > >can
>> > > >discuss it post-2.0.
>> > > >
>> > > >(2) If we consider that a goal for the class GenericObjectPool is 
>> that it
>> > > >be
>> > > >customizable on top of "configurable" (Javadoc comment), by which 
>> I mean
>> > > >extendable/subclassable, then we should change the protection of 
>> fields
>> > >and
>> > > >methods from private to protected to allow for this to happen. 
>> This is
>> > >not
>> > > >the first time that we have seen the suggestion that a 
>> feature/bug could
>> > > >have been addressed by subclassing but that in fact could not due to
>> > > >field/method protection. (I am leaving aside the fact that one 
>> can change
>> > > >any code in [pool] and recompile).
>> > > >
>> > > >Thoughts?
>> > > >
>> > > >Gary
>> > > >
>> > > >-----Original Message-----
>> > > >From: James Mitchell [mailto:jmitchell@apache.org]
>> > > >Sent: Thursday, April 17, 2003 4:16 AM
>> > > >To: jakarta-commons-dev@apache.org
>> > > >Subject: [Pool] What's left for a release?
>> > > >
>> > > >Initial search in bugzilla for pool turned up 3 bugs (ok, 2 bugs 
>> and 1
>> > > >Enhancement).  The 2 bugs that were there have patches available.
>> > > >
>> > > >I was wondering if there were any specific reasons (other than
>> > > >time/resources)
>> > > >that those patches had not been committed.
>> > > >
>> > > >We are pushing for a RC2 over in the Struts camp and we depend on 
>> a new
>> > > >release of Pool.  I'd like to help with this if I can.
>> > > >
>> > > >Your thoughts?
>> > > >
>> > > >
>> > > >--
>> > > >James Mitchell
>> > > >Software Developer/Struts Evangelist
>> > > >http://www.open-tools.org
>> > > >
>> > > >
>> > > >
>> > > >
>> > > 
>> >---------------------------------------------------------------------
>> > > >To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>> > > >For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>> > >
>> > >
>> > >_________________________________________________________________
>> > >MSN 8 helps eliminate e-mail viruses. Get 2 months FREE*.
>> > >http://join.msn.com/?page=features/virus
>> > >
>> > >
>> > >---------------------------------------------------------------------
>> > >To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>> > >For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>> >
>> >
>> > _________________________________________________________________
>> > Add photos to your e-mail with MSN 8. Get 2 months FREE*.
>> > http://join.msn.com/?page=features/featuredemail
>> >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>>
> 
> 
> _________________________________________________________________
> MSN 8 helps eliminate e-mail viruses. Get 2 months FREE*.  
> http://join.msn.com/?page=features/virus



---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org