[GitHub] [airflow] madison-ookla commented on a change in pull request #13371: Add clearer exception for read failures in macro plugin upgrade check

[GitBox <gi...@apache.org>]

madison-ookla commented on a change in pull request #13371:
URL: https://github.com/apache/airflow/pull/13371#discussion_r551533352



##########
File path: airflow/upgrade/rules/airflow_macro_plugin_removed.py
##########
@@ -39,9 +39,16 @@ def _check_file(self, file_path):
         problems = []
         class_name_to_check = self.MACRO_PLUGIN_CLASS.split(".")[-1]
         with open(file_path, "r") as file_pointer:
-            for line_number, line in enumerate(file_pointer, 1):
-                if class_name_to_check in line:
-                    problems.append(self._change_info(file_path, line_number))
+            try:
+                for line_number, line in enumerate(file_pointer, 1):
+                    if class_name_to_check in line:
+                        problems.append(self._change_info(file_path, line_number))
+            except UnicodeDecodeError:
+                raise Exception(
+                    "Unable to read file {}, it may need to be added to the .airflowignore".format(

Review comment:
       More than happy to add this to the problems report! My gut instinct for big projects like this is "preserve existing behavior by default", so I didn't want to change things up too much initially 😄  Also good to know on the macros! I can add that to the logic as well. Can they be python files that don't have the `.py` extension but are ostensibly python otherwise?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org