You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by bso-intel <gi...@git.apache.org> on 2015/12/08 19:42:45 UTC
[GitHub] cordova-lib pull request: CB-8455 added --nohooks option
GitHub user bso-intel opened a pull request:
https://github.com/apache/cordova-lib/pull/353
CB-8455 added --nohooks option
implemented --nohooks noption as described in CB-8455
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bso-intel/cordova-lib CB-8455
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/353.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #353
----
commit d77c2d27bbf785f1c2471156f36693e5ce06b9dd
Author: Byoungro So <by...@intel.com>
Date: 2015-12-08T04:53:43Z
added --nohooks option
commit f8a430ccf5fc1db7f555dcbbd84651c3da7ca5f6
Author: Byoungro So <by...@intel.com>
Date: 2015-12-08T04:53:43Z
CB-8455 added --nohooks option
commit b4be9c724a70d819975f50b615da9a7203ad85e5
Author: Byoungro So <by...@intel.com>
Date: 2015-12-08T05:04:03Z
Merge branch 'CB-8455' of https://github.com/bso-intel/cordova-lib into CB-8455
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8455 added --nohooks option
Posted by bso-intel <gi...@git.apache.org>.
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/353#issuecomment-163324816
Hi Vladmir,
Exactly.
The pre-package hooks on for the windows* platforms run when LIB prepares for the source.
To suppress this hook, HookRunner needs the option "--nohooks pre_package" that is propagated from the command line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8455 added --nohooks option
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/353#issuecomment-163066579
This feature has much deeper and far reaching requirements, as the CI has pointed out.
The individual platforms are all keeping their own parsers, and because this affects the platform-api ALL platforms must be updated for this to work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8455 added --nohooks option
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/353
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8455 added --nohooks option
Posted by bso-intel <gi...@git.apache.org>.
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/353#issuecomment-165950086
Hi Vladimir,
Thank you very much for reviewing.
I addressed your feedback and added several unit tests in LIB and CLI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8455 added --nohooks option
Posted by bso-intel <gi...@git.apache.org>.
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/353#issuecomment-165619803
HI Jesse and Vladimir,
If there is no more comment, could you pull my branch CB-8455 so the next Cordova release contains this feature?
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8455 added --nohooks option
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/353#issuecomment-165732453
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8455 added --nohooks option
Posted by bso-intel <gi...@git.apache.org>.
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/353#issuecomment-166358228
Thank you very much for merging, Vladimir.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8455 added --nohooks option
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/353#discussion_r48008986
--- Diff: cordova-lib/src/hooks/HooksRunner.js ---
@@ -87,6 +93,12 @@ module.exports = HooksRunner;
*/
module.exports.fire = globalFire;
function globalFire(hook, opts) {
+ if (isHookDisabled(opts, hook)) {
+ /* jshint -W064 */
--- End diff --
Just a minor nit: do we need for this ignores? We don't have neither 'strict mode' nor JSHint `newcap` option enabled, so this is probably just a no-op.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8455 added --nohooks option
Posted by bso-intel <gi...@git.apache.org>.
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-lib/pull/353#issuecomment-163090076
Hi Jesse,
The CI failures actually were caused by not checking the existence of the opts parameter.
In the spec unit tests, update_project() was invoked without the opts parameter that I added in windows_parser.js and wp8_parser.js.
I have fixed the issues, and now all tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8455 added --nohooks option
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/353#issuecomment-163182113
Isn't hooks is a CLI/LIB feature? As far as I remember, hooks fired by LIB except for `pre_package` hook for wp8/windows, so probably there is no need to pass the option down to platforms.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org