You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by ceharris <gi...@git.apache.org> on 2017/10/09 11:27:19 UTC
[GitHub] incubator-guacamole-manual pull request #59: WIP: GUACAMOLE-406: Add documen...
GitHub user ceharris opened a pull request:
https://github.com/apache/incubator-guacamole-manual/pull/59
WIP: GUACAMOLE-406: Add documentation for event listener support
I think this is at a point where some review would be helpful. Would appreciate feedback on the content itself (especially level of detail, illustrative value of the examples, etc), placement in the user manual structure, as well as any syntactic issues.
There is some repetition between this section and the section on custom authentication providers. In particular, the instructions for installing a custom extension are duplicated almost verbatim. Perhaps this would be better addressed in the chapter on guacamole-ext or elsewhere.
Much of the skeleton for the example itself is also very similar to the authentication provider example, but I think this is probably to be expected and may not be a bad thing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soulwing/incubator-guacamole-manual GUACAMOLE-406-rebase
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-manual/pull/59.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #59
----
commit a7a58d4874d11d6a76bb48e9401a92060b100f49
Author: Carl Harris <ce...@vt.edu>
Date: 2017-10-08T18:11:41Z
GUACAMOLE-406: first draft of event listener chapter
commit 52e189d0c9b85f500ed6f76746d4d8bd21724278
Author: Carl Harris <ce...@vt.edu>
Date: 2017-10-08T18:12:18Z
GUACAMOLE-406: document new listeners manifest property
commit d2ec4cdf5661c11e9ea632fa7af0714e2ac43b33
Author: Carl Harris <ce...@vt.edu>
Date: 2017-10-08T18:13:31Z
GUACAMOLE-406: link event listener chapter into user guide
commit 2af6488fa7359116055ee8efb16cbe7c2774d4c2
Author: Carl Harris <ce...@vt.edu>
Date: 2017-10-09T11:24:50Z
GUACAMOLE-406: revisions based on proofreading
----
---
[GitHub] incubator-guacamole-manual pull request #59: GUACAMOLE-406: Add documentatio...
Posted by ceharris <gi...@git.apache.org>.
Github user ceharris closed the pull request at:
https://github.com/apache/incubator-guacamole-manual/pull/59
---